Update chat memory example and separate ChatMemoryStore from ChatMemory usage #107
Conversation
| @Override | ||
| public ChatMemory get(Object memoryId) { | ||
| return MessageWindowChatMemory.builder() | ||
| .id(memoryId) |
There was a problem hiding this comment.
without eviction or4 cleanup, this will lead to OOM.
There was a problem hiding this comment.
I need to see exactly how this is meant to work.
There was a problem hiding this comment.
Yes, there is currently no eviction mechanism. However, for a simple example, that would be hard to do. The current idea of always evicting when the request ends makes a chat with API calls impossible.
I added a note to the documentation clarifying this.
There was a problem hiding this comment.
The documentation should mention or have a more complex example with eviction.
I'm still unsure about the request scope part. I think, we would need to introduce a "conversation" concept soon.
andreas-eberle
force-pushed
the
feature/update-chat-memory-example
branch
from
c7c4821 to
6be3de2
Compare
|
I am looking into a little more. There is a chance that things are simpler than we think |
|
I took the suggestion to use Thanks for bringing up this idea! |
This PR updates the ChatMemory example. The idea is to separate providing the
ChatMemorycreation in theChatMemoryProviderBeanand theChatMemoryStorecreation via aChatMemoryStoreProducer.