-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LangChain4j 1.0.0-alpha1 & Model Context Protocol client implementation and sample #1171
Conversation
Very cool @jmartisk! Can you provide a list of things that need to be done in order for this to move out of draft? |
Yea I think it's basically ready except we need a langchain4j release that integrates this. If the langchain4j side gets any changes before the release, we might obviously need to adjust here. |
Cool thanks. @langchain4j do you a timeline in your head about when the next LangChain4j release will go out? |
@geoand targeting for tomorrow, but most probably this Friday |
Awesome, thanks! |
We'll probably also need @cescoffier's writing talents on this one :) |
I'm planning to write up a blog post too :) |
Seems we have a server-side framework ready (https://github.com/quarkiverse/quarkus-mcp-server/releases/tag/1.0.0.Alpha1), I'll probably try to add some tests that run our client against our server (rather than a dumb mock server). That could go into a new module inside |
Makes perfect sense to me! |
Makes sense! Keep in mind that it's still very alpha ;-). |
As if we needed convincing of whether to ship it 😂 |
Ok this will need some adjustments after langchain4j/langchain4j#2315 |
I've pushed an upgrade to LangChain4j 1.0.0-alpha1 as part of this. Haven't had time for the integration test yet, that may have to wait until after Christmas. |
mcp/runtime/src/main/java/io/quarkiverse/langchain4j/mcp/runtime/config/McpClientConfig.java
Outdated
Show resolved
Hide resolved
mcp/runtime/src/main/java/io/quarkiverse/langchain4j/mcp/runtime/config/McpConfiguration.java
Show resolved
Hide resolved
...ntime/src/main/java/io/quarkiverse/langchain4j/mcp/runtime/http/QuarkusHttpMcpTransport.java
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
312da89
to
40ea975
Compare
This comment has been minimized.
This comment has been minimized.
Tests are passing now, except some Ollama stuff that fails with 404s, not sure what that is, it doesn't look related to the change?! |
This comment has been minimized.
This comment has been minimized.
But those tests pass in |
Ah, a Wiremock declaration needed a slight change, hopefully, I've fixed it now... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome stuff!
This comment has been minimized.
This comment has been minimized.
Status for workflow
|
I can't release because I am getting: [WARNING] The POM for io.quarkiverse.langchain4j:quarkus-langchain4j-mcp-deployment:jar:999-SNAPSHOT is missing, no dependency information available
[ERROR] Quarkus Extension Dependency Verification Error
[ERROR] Deployment artifact io.quarkiverse.langchain4j:quarkus-langchain4j-mcp-deployment::jar:999-SNAPSHOT was found to be missing dependencies on the Quarkus extension artifacts marked with '-' below:
[ERROR] - io.quarkiverse.langchain4j:quarkus-langchain4j-mcp::jar
[ERROR] - io.quarkus:quarkus-arc-deployment::jar
[ERROR] - io.quarkus:quarkus-core-deployment::jar
[ERROR] - io.quarkus:quarkus-rest-client-jackson-deployment::jar
[ERROR] - io.quarkus:quarkus-rest-jackson-common-deployment::jar
[ERROR] - io.quarkus:quarkus-rest-common-deployment::jar
[ERROR] - io.quarkus:quarkus-jsonp-deployment::jar
[ERROR] - io.quarkus:quarkus-rest-client-deployment::jar
[ERROR] - io.quarkus:quarkus-rest-client-jaxrs-deployment::jar
[ERROR] - io.quarkus:quarkus-smallrye-stork-deployment::jar
[ERROR] - io.quarkus:quarkus-rest-client-config-deployment::jar
[ERROR] - io.quarkus:quarkus-tls-registry-deployment::jar
[ERROR] - io.quarkiverse.langchain4j:quarkus-langchain4j-core-deployment::jar
[ERROR] - io.quarkus:quarkus-jackson-deployment::jar
[ERROR] - io.quarkus:quarkus-qute-deployment::jar
[ERROR] - io.quarkus:quarkus-vertx-deployment::jar
[ERROR] - io.quarkus:quarkus-netty-deployment::jar
[ERROR] - io.quarkus:quarkus-mutiny-deployment::jar
[ERROR] - io.quarkus:quarkus-smallrye-context-propagation-deployment::jar
[ERROR] - io.quarkus:quarkus-virtual-threads-deployment::jar Nothing in the extension looks out of the ordinary... |
From the log, it seems the |
Yeah, I'm trying to compare with other modules to see if there are any useful hints |
I tend to think that #1181 will fix it |
Ah, you beat me to it :) |
Fixes #1146