Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide Evaluations in same order as they where submitted #1213

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

flyinfish
Copy link

as discussed https://github.com/quarkiverse/quarkus-langchain4j/pull/1209/files#r1908303398

this change provides

  • stable order for scorer.evaluate(...)
  • generic typed EvaluationReport<T> report = scorer.evaluate(...);
    @cescoffier or is it by purpose that EvaluationReport was not generically typed? i stumbled upon it having some compile-issues when sorting

@flyinfish flyinfish requested a review from a team as a code owner January 10, 2025 10:01

This comment has been minimized.

Copy link

quarkus-bot bot commented Jan 10, 2025

Status for workflow Build (on pull request)

This is the status report for running Build (on pull request) on commit 4c93baf.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@geoand geoand merged commit e0f1362 into quarkiverse:main Jan 10, 2025
70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants