Milvus embedding store + Dev services #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartisk
force-pushed
the
milvus-official-grpc
branch
from
7642aa6 to
86d60f5
Compare
jmartisk
changed the title
jmartisk
force-pushed
the
milvus-official-grpc
branch
from
86d60f5 to
1fd164f
Compare
Hopefully at some point in the future we can use our own which would allow us to reap the many benefits as you mentioned |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I had to go with the official Milvus Java client in the end, and that contains some crazy dependencies that probably prevent us from compiling in native for now.
I tried a REST client, but Milvus's REST api seems quite unfinished and doesn't seem to allow specifying the schema of a newly being created collection.
But hey, with this approach, it should be relatively low amount of maintenance work for us, because we basically just take what langchain4j has, without changes.
The bad part is that since we're using their gRPC client it's not integrated with the gRPC extension (so no metrics, tracing etc)