Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of new stuff in the Redis DataSource API #16

Merged
merged 3 commits into from
Nov 26, 2023

Conversation

jmartisk
Copy link
Collaborator

@jmartisk jmartisk commented Nov 14, 2023

Needs Quarkus 3.6.0

@geoand
Copy link
Collaborator

geoand commented Nov 20, 2023

I assume we can use 3.6.0.CR1 for this, right?

@jmartisk jmartisk marked this pull request as ready for review November 20, 2023 09:01
@jmartisk jmartisk requested a review from a team as a code owner November 20, 2023 09:01
@jmartisk
Copy link
Collaborator Author

I guess so! I've added the upgrade to this PR, let's see

Copy link
Collaborator

@geoand geoand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd like @cescoffier to weigh in

@geoand
Copy link
Collaborator

geoand commented Nov 20, 2023

I rebased this onto main in order to make sure everything still works with the latest changes I made there.

@geoand geoand requested a review from cescoffier November 20, 2023 11:35
@jmartisk
Copy link
Collaborator Author

I've updated Quarkus from 3.6.0.CR1 to 3.6.0 now.

@geoand
Copy link
Collaborator

geoand commented Nov 24, 2023

@cescoffier can you please review?

Copy link
Collaborator

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@cescoffier cescoffier merged commit 2daac44 into quarkiverse:main Nov 26, 2023
1 of 2 checks passed
@jmartisk jmartisk deleted the redis-vectors branch November 28, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants