Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial OpenTelemetry support for declarative services #77

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

geoand
Copy link
Collaborator

@geoand geoand commented Dec 1, 2023

For the email-me-a-pom example, the outcome looks like:

Screenshot from 2023-12-01 12-48-22

Note that it contains a span for the service, spans for the REST calls (we get those for free) and a span for the tool invocation

Relates to: #8

@geoand geoand requested a review from a team as a code owner December 1, 2023 10:49
@geoand
Copy link
Collaborator Author

geoand commented Dec 1, 2023

I also need to write docs for this.

In the future we probably want to enhance each span with additional metadata, but that can certainly wait for future releases.

Copy link
Collaborator

@cescoffier cescoffier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@geoand
Copy link
Collaborator Author

geoand commented Dec 1, 2023

Added documentation as well

@geoand geoand merged commit 1ba5659 into main Dec 4, 2023
1 of 2 checks passed
@geoand geoand deleted the opentelemetry branch December 4, 2023 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants