-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sketch out API for auditing #83
Conversation
a3c3c0d
to
a61cc5d
Compare
@cescoffier WDYT? It's very bare bones ATM, but I think it's fine for a first version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's exactly what I had in mind.
I still need to add some documentation entry |
@jmartisk the pinecone test is failing, do you have any idea? |
Hard to say, maybe some other CI was running in parallel with it? |
I'll try to run the tests for this PR on my laptop |
One thing I am thinking we should do is introduce the Git Incremental Builder by @famod that we also use in Quarkus, as it an awesome way of only running tests for modules that can be affected by a change |
I see you re-ran the tests and the Pinecone tests passed this time, but there's some other failures this time.... lovely |
On this current run it seems like pinecode failed again |
There is something very weird going on with the native tests that requires more investigation |
Happy to help! I should have some time for that later this month. Best create an issue with some details and assign it to me. 🙂 |
Will do, thanks! |
78fbbf5
to
16d9da4
Compare
Relates to: #8
No description provided.