Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add format for google cloud platform #158

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johnnystargazer
Copy link

@DPGrev
Copy link

DPGrev commented Feb 9, 2022

Nice PR! We are also waiting for this to merged.

@gsmet gsmet mentioned this pull request Aug 29, 2022
@ayhanap
Copy link

ayhanap commented Oct 20, 2022

Would love to see this merged, any help needed?

@SlyngDK
Copy link
Contributor

SlyngDK commented Oct 20, 2022

I have not used GCP by my self, and there are two different PRs not with same fields.
For me I am not sure what the correct format is, I think its maybe better just disable all the defaults fields, and create own JsonProvider, with all the fields wanted.

@ayhanap
Copy link

ayhanap commented Oct 20, 2022

Ok, I will analyze both PRs and list differences. There are many optional fields but the critical fields are severity and message(containing stacktrace). Without these, all logs are shown as default severity and there is no automatic ErrorReporting out of stacktraces.

As reference, these are the docs for json fields.

https://cloud.google.com/logging/docs/structured-logging
https://cloud.google.com/logging/docs/reference/v2/rest/v2/LogEntry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants