Add property additional-properties-as-attribute configuration #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcruzdev
changed the title
|
Hi @ricardozanini, @hbelmiro, can you review this pull request? Edit: I forgot the documentation, could I add the documentation in |
@mcruzdev Yes, and add a link to that in README.md, please. |
hbelmiro
reviewed
Sep 30, 2023
...penapi/generator/additionalproperties/QuarkusAdditionalPropertiesAsAttributeAsFalseTest.java
Show resolved
Hide resolved
deployment/src/main/resources/templates/libraries/microprofile/pojo.qute
Outdated
Show resolved
Hide resolved
hbelmiro
approved these changes
Oct 1, 2023
ricardozanini
approved these changes
Oct 3, 2023
|
Just waiting for @ayhanap's validation before merging. |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
* feat: add property additional-properties-as-attribute * refactor: format the code with mvn verify * feat: create pojoAdditionalProperties.qute file * test: add integration test * test: update tests * test: add more test to make sure the issue solution * refactor: use FQN and add docs * refactor(test): add instanceOf assertion * refactor: format code
7 tasks
hbelmiro
added a commit
that referenced
this pull request
Oct 3, 2023
…ion (#512) * Add property additional-properties-as-attribute configuration (#504) * feat: add property additional-properties-as-attribute * refactor: format the code with mvn verify * feat: create pojoAdditionalProperties.qute file * test: add integration test * test: update tests * test: add more test to make sure the issue solution * refactor: use FQN and add docs * refactor(test): add instanceOf assertion * refactor: format code * Replaced jakarta with javax Fixed version --------- Co-authored-by: Matheus Cruz <[email protected]> Co-authored-by: Helber Belmiro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #442
When Jackson try to serialize/deserialize using a class that inherit of
HashMap, there are some issues.On deserialization throws
MismatchInputExceptionand on serialization does not get plain fields.Please make sure that your PR meets the following requirements:
[0.9.x] SubjectHow to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-quarkus2to backport the original PR to thequarkus2branch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.