Configure authentication at Build time #795

rmanibus · 2024-09-12T17:55:15Z

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

You have read the contributors guide
Your code is properly formatted according to our code style
Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
Pull Request contains link to the issue
Pull Request contains link to any dependent or related Pull Request
Pull Request contains description of the issue
Pull Request does not include fixes for issues other than the main ticket

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

.../src/main/java/io/quarkiverse/openapi/generator/ReactiveOidcClientRequestFilterDelegate.java

.../io/quarkiverse/openapi/generator/providers/BuildTimeAbstractAuthenticationProviderTest.java

rmanibus · 2024-09-14T23:06:05Z

there is an issue with the fact that I made the OIDC Filter extension optional. I provided a temporary fix by removing the dependency to AbstractOidcClientRequestReactiveFilter and AbstractOidcClientRequestFilter (see 334c66f),
but there is probably a better way of doing this.

before the fix,
with rest easy classic the build hung with the following error:

2024-09-14 19:00:36,019 WARN [io.qua.arc.pro.BeanArchives] (build-17) Failed to index io.quarkus.oidc.client.reactive.filter.runtime.AbstractOidcClientRequestReactiveFilter: Class does not exist in ClassLoader QuarkusClassLoader:Deployment Class Loader: TEST for BeanValidationTest (QuarkusTest)@4bbf38b8

with rest easy reactive the build hung with the following error:

2024-09-14 18:54:22,716 WARN [io.qua.arc.pro.BeanArchives] (build-12) Failed to index io.quarkus.oidc.client.filter.runtime.AbstractOidcClientRequestFilter: Class does not exist in ClassLoader QuarkusClassLoader:Deployment Class Loader: TEST for BeanValidationTest (QuarkusTest)@1c30cb85

...deployment/src/main/java/io/quarkiverse/openapi/generator/deployment/GeneratorProcessor.java

...e/src/main/java/io/quarkiverse/openapi/generator/ClassicOidcClientRequestFilterDelegate.java

.../src/main/java/io/quarkiverse/openapi/generator/ReactiveOidcClientRequestFilterDelegate.java

...deployment/src/main/java/io/quarkiverse/openapi/generator/deployment/GeneratorProcessor.java

mcruzdev

Hi @rmanibus, amazing Job! I just added a simple comment

rmanibus · 2024-09-18T11:45:48Z

@mcruzdev I fixed the imports !

mcruzdev · 2024-09-18T13:36:40Z

@mcruzdev I fixed the imports !

I learned a lot, thank you for this pull request!

rmanibus · 2024-09-23T08:41:52Z

@mcruzdev you are very welcome ! Any chance to get this approved again ? The force push dropped the review

hbelmiro

Thank you for this contribution @rmanibus. Nicely done!
I just left some aesthetical nits.

...e/src/main/java/io/quarkiverse/openapi/generator/providers/ApiKeyAuthenticationProvider.java

...java/io/quarkiverse/openapi/generator/deployment/authentication/OpenApiSpecProviderTest.java

...e/src/main/java/io/quarkiverse/openapi/generator/ClassicOidcClientRequestFilterDelegate.java

client/runtime/src/main/java/io/quarkiverse/openapi/generator/OidcClient.java

client/runtime/src/main/java/io/quarkiverse/openapi/generator/OpenApiSpec.java

.../src/main/java/io/quarkiverse/openapi/generator/ReactiveOidcClientRequestFilterDelegate.java

rmanibus · 2024-09-24T11:56:49Z

@hbelmiro thanks a lot ! It is done !

.../src/main/java/io/quarkiverse/openapi/generator/ReactiveOidcClientRequestFilterDelegate.java

hbelmiro

Thank you @rmanibus.

fjtirado · 2024-09-26T19:21:39Z

...rc/main/java/io/quarkiverse/openapi/generator/providers/CompositeAuthenticationProvider.java

-    public final void addAuthenticationProvider(final AuthProvider authProvider) {
-        this.authProviders.add(authProvider);
+    public CompositeAuthenticationProvider(List<AuthProvider> authProviders) {
+        this.authProviders = List.copyOf(authProviders);


Why do we need to copy this? As far as I can see authProviders is not modified, isnt it?

I wanted it to be immutable

there is a public getter on it

ricardozanini · 2024-09-26T20:01:51Z

@wmedvede will also look since he made many changes to this code, too.

rmanibus · 2024-10-07T13:19:26Z

Any updates about this ?

github-advanced-security bot found potential problems Sep 12, 2024

View reviewed changes

rmanibus force-pushed the build_time branch 12 times, most recently from 67ccec9 to 74a5b9b Compare September 13, 2024 14:16

rmanibus marked this pull request as ready for review September 13, 2024 14:17

rmanibus force-pushed the build_time branch 9 times, most recently from 345641f to 56acf4b Compare September 14, 2024 21:18

rmanibus force-pushed the build_time branch 2 times, most recently from a8a9251 to 334c66f Compare September 14, 2024 23:09

github-advanced-security bot found potential problems Sep 14, 2024

View reviewed changes

rmanibus force-pushed the build_time branch from 5bf62fb to 44e9b5c Compare September 15, 2024 13:23

ricardozanini requested review from ricardozanini and hbelmiro September 16, 2024 21:46

ricardozanini requested a review from mcruzdev September 16, 2024 21:46

mcruzdev reviewed Sep 17, 2024

View reviewed changes

...deployment/src/main/java/io/quarkiverse/openapi/generator/deployment/GeneratorProcessor.java Outdated Show resolved Hide resolved

mcruzdev approved these changes Sep 17, 2024

View reviewed changes

rmanibus force-pushed the build_time branch from 44e9b5c to e750fda Compare September 18, 2024 11:45

rmanibus requested a review from a team as a code owner September 18, 2024 11:45

rmanibus force-pushed the build_time branch from e750fda to 5e48fd9 Compare September 18, 2024 13:28

mcruzdev approved these changes Sep 23, 2024

View reviewed changes

ricardozanini requested a review from fjtirado September 23, 2024 16:25

hbelmiro reviewed Sep 23, 2024

View reviewed changes

rmanibus force-pushed the build_time branch 3 times, most recently from 741b9c4 to 1dec5c4 Compare September 24, 2024 11:45

Configure authentication at Build time

405bac8

rmanibus force-pushed the build_time branch from 1dec5c4 to 405bac8 Compare September 24, 2024 11:53

github-advanced-security bot found potential problems Sep 24, 2024

View reviewed changes

.../src/main/java/io/quarkiverse/openapi/generator/ReactiveOidcClientRequestFilterDelegate.java Dismissed Show dismissed Hide dismissed

hbelmiro approved these changes Sep 25, 2024

View reviewed changes

fjtirado reviewed Sep 26, 2024

View reviewed changes

fjtirado approved these changes Sep 26, 2024

View reviewed changes

ricardozanini approved these changes Sep 26, 2024

View reviewed changes

Merge branch 'main' into build_time

a55ca04

ricardozanini merged commit d2dd0ce into quarkiverse:main Oct 7, 2024
10 checks passed

ricardozanini mentioned this pull request Oct 16, 2024

Build fails if quarkus-oidc-client is not in the classpath #824

Closed

marko-bekhta mentioned this pull request Nov 11, 2024

Consistently use quarkus-generator.openApiSpecId as openApiSpecId in templates #848

Merged

7 tasks

github-actions bot mentioned this pull request Nov 12, 2024

[main-lts] Consistently use quarkus-generator.openApiSpecId as openApiSpecId in templates #849

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Configure authentication at Build time #795

Configure authentication at Build time #795

rmanibus commented Sep 12, 2024 •

edited by ricardozanini

Loading

rmanibus commented Sep 14, 2024 •

edited

Loading

mcruzdev left a comment

rmanibus commented Sep 18, 2024

mcruzdev commented Sep 18, 2024

rmanibus commented Sep 23, 2024

hbelmiro left a comment

rmanibus commented Sep 24, 2024

hbelmiro left a comment

fjtirado Sep 26, 2024 •

edited

Loading

rmanibus Sep 26, 2024

rmanibus Sep 26, 2024

ricardozanini commented Sep 26, 2024 •

edited

Loading

rmanibus commented Oct 7, 2024

Configure authentication at Build time #795

Configure authentication at Build time #795

Conversation

rmanibus commented Sep 12, 2024 • edited by ricardozanini Loading

rmanibus commented Sep 14, 2024 • edited Loading

mcruzdev left a comment

Choose a reason for hiding this comment

rmanibus commented Sep 18, 2024

mcruzdev commented Sep 18, 2024

rmanibus commented Sep 23, 2024

hbelmiro left a comment

Choose a reason for hiding this comment

rmanibus commented Sep 24, 2024

hbelmiro left a comment

Choose a reason for hiding this comment

fjtirado Sep 26, 2024 • edited Loading

Choose a reason for hiding this comment

rmanibus Sep 26, 2024

Choose a reason for hiding this comment

rmanibus Sep 26, 2024

Choose a reason for hiding this comment

ricardozanini commented Sep 26, 2024 • edited Loading

rmanibus commented Oct 7, 2024

rmanibus commented Sep 12, 2024 •

edited by ricardozanini

Loading

rmanibus commented Sep 14, 2024 •

edited

Loading

fjtirado Sep 26, 2024 •

edited

Loading

ricardozanini commented Sep 26, 2024 •

edited

Loading