Adding NotNull annotation for required fields #810
Conversation
…no other constraint).
| Field size = ValidatedObject.class.getDeclaredField("size"); | ||
|
|
||
| assertThat(Arrays.stream(ValidatedObject.class.getFields()) | ||
| assertThat(Stream.of(id, name, secondName, size) |
There was a problem hiding this comment.
Just to be sure, have you changed this only for performance reasons?
There was a problem hiding this comment.
Actually not.
getFields method returns only public fields and the generated class consists only of private ones. It makes ValidatedObject.class.getFields() always returning an empty array.
By this reason the following assertion has no chance to fail.
assertThat(Arrays.stream(UnvalidatedObject.class.getFields())
.allMatch(f -> f.isAnnotationPresent(NotNull.class)))
getDeclaredFields() method would be more appropriate (instead of getFields), but I decided to utilize the objects returned by getDeclaredField calls a few lines above.
I've just added a similar change also in testValidationAnnotationsAreSkippedModel test method.
getFields method returns only `public` fields and the generated class consists only of private ones.
It makes ValidatedObject.class.getFields() always returning an empty array.
Following assertion has no chance to fail
assertThat(Arrays.stream(UnvalidatedObject.class.getFields())
.noneMatch(f -> f.isAnnotationPresent(NotNull.class))).isTrue();
|
@allcontributors add @michalkolenda for code |
|
I've put up a pull request to add @michalkolenda! 🎉 |
Following changes concern generating POJOs using client with
use-bean-validationproperty set totrue.There is a functionality of annotating required fields with Jakarta @NotNull. According to my tests, it does not work in case when the field has no other constraints (like minLength, maxLength, etc.). I expect that required fields are annotated with NotNull no matter it has any other constraints or not.
I would suggest a little modification in pojo.qute in order to annotate every required field.