Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support discriminator mappings for polymorphism #830

Merged
merged 1 commit into from
Oct 27, 2024

Conversation

brice-laurencin
Copy link
Contributor

@brice-laurencin brice-laurencin commented Oct 25, 2024

Fix #520.

This PR adds JsonTypeInfo and JsonSubTypes matching the mappings so objects are properly deserialized to subtypes.

@brice-laurencin brice-laurencin marked this pull request as ready for review October 25, 2024 14:01
@brice-laurencin brice-laurencin requested a review from a team as a code owner October 25, 2024 14:01
Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems pretty straightforward to me.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @brice-laurencin.

@hbelmiro hbelmiro merged commit 6dccf8e into quarkiverse:main Oct 27, 2024
11 checks passed
@gerardbosch
Copy link

Hi @ricardozanini is this merge released? or can I use the version that contains it? Thank you!

@ricardozanini
Copy link
Member

@gerardbosch not yet, I'll do a release today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

discriminator seems not to be supported to manage polymorphism
4 participants