-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added feature to set schema mappings when generation clients. #846
Added feature to set schema mappings when generation clients. #846
Conversation
Strange that the build failed, it (as usual) worked when I tried it with |
@denvitaharen take a look at https://github.com/quarkiverse/quarkus-openapi-generator/blob/main/CONTRIBUTING.md#resteasy-reactive-and-resteasy-classic for testing RESTEasy Reactive locally. |
Sorry, my bad! I didn't noticed the different profiles, probably to tired to understand :) I have updated the test, rerun the test suite and it works now. |
I updated the definition of YearMonth in the OpenAPI yaml. It was incorrect, it represented an LocalDateTime instead of an YearMonth. It doesn't change anything in the functionality, it's more about having a correct OpenAPI specification. Thanks to my colleague @sajox that saw the error. |
Hi! Do you have any feedback on my pull request? |
Sorry @denvitaharen. |
* Added feature to set schema mappings when generation clients. * Updated Restreactive test with schemamapping * Updated the YearMonth schema to be correct format. * Updated the documentation --------- Co-authored-by: Ricardo Zanini <[email protected]>
…879) * Added feature to set schema mappings when generation clients. * Updated Restreactive test with schemamapping * Updated the YearMonth schema to be correct format. * Updated the documentation --------- Co-authored-by: Richard Alm <[email protected]> Co-authored-by: Ricardo Zanini <[email protected]>
When we tried to migrate from specifying our own openapi generator in Maven to Quarkus OpenAPI generator we realized that we missed the possibility two specify schema mappings: https://openapi-generator.tech/docs/customization/#schema-mapping
Its possible to specify that in the OpenAPI generator, so it was just to expose it so you can set it in the application.properties.
Updated the type mapping test and updated the documentation, hopefully I did all I supposed to do, this is my first attempt to help in an public repo :)