Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main-lts] Fix #824 - Introduce a separated OIDC module to hold security dependencies #874

Open
wants to merge 1 commit into
base: main-lts
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

Backport: #872

Note: CI is not automatically triggered on backported PRs, please comment 'ok to test' to launch Jenkins jobs

Fix #824

In this PR:

  • Removed references of OIDC libraries from the main runtime module
  • I created a separate quarkus-openapi-generator-oidc component to hold OIDC use cases; users now MUST add this new dependency to their project in case OIDC is required.
  • Review the integration-tests module to remove OIDC from every module; just add to security where it's really required.
  • Updated documentation.

Many thanks for submitting your Pull Request ❤️!

Please make sure that your PR meets the following requirements:

  • You have read the contributors guide
  • Your code is properly formatted according to our code style
  • Pull Request title contains the target branch if not targeting main: [0.9.x] Subject
  • Pull Request contains link to the issue
  • Pull Request contains link to any dependent or related Pull Request
  • Pull Request contains description of the issue
  • Pull Request does not include fixes for issues other than the main ticket
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-quarkus2 to backport the original PR to the quarkus2 branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

…ncies (#872)

* Fix #824 - Introduce a separated OIDC module to hold security dependencies

Signed-off-by: Ricardo Zanini <[email protected]>

* Fix  parent module

Signed-off-by: Ricardo Zanini <[email protected]>

---------

Signed-off-by: Ricardo Zanini <[email protected]>
@hbelmiro
Copy link
Contributor

@ricardozanini can you please check the CI?

@ricardozanini
Copy link
Member

@ricardozanini can you please check the CI?

Fixed in #882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants