Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.2.0 #169

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Release 3.2.0 #169

merged 1 commit into from
Sep 20, 2023

Conversation

vsevel
Copy link
Contributor

@vsevel vsevel commented Sep 20, 2023

@vsevel
Copy link
Contributor Author

vsevel commented Sep 20, 2023

@geoand or @gastaldi can you validate?

@kdubb
Copy link
Contributor

kdubb commented Sep 20, 2023

Is there test coverage for failure we are working around in Quarkus main?

@vsevel
Copy link
Contributor Author

vsevel commented Sep 20, 2023

Is there test coverage for failure we are working around in Quarkus main?

at this point all of what we are going is replacing VertxRecorder with VertxEventBusConsumerRecorder because of the renaming (or transfer of functionality) in 3.4
we are essentially fixing something that is broken. in that sense yes we have some test coverage.
I will go ahead and release. we will continue the discussion in the context of 3.5

@vsevel vsevel merged commit 2e5105b into main Sep 20, 2023
2 checks passed
@vsevel vsevel deleted the release_3.2.0 branch September 20, 2023 10:07
@vsevel
Copy link
Contributor Author

vsevel commented Sep 20, 2023

must have missed again something it did not create the tag
@gastaldi are you available to help?

@gsmet
Copy link
Member

gsmet commented Sep 20, 2023

@vsevel there was a test failure during the release:

 Error: [ERROR] Tests run: 28, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.763 s <<< FAILURE! -- in io.quarkus.vault.VaultTransitITCase
Error: [ERROR] io.quarkus.vault.VaultTransitITCase.keyVersionSignBatch -- Time elapsed: 0.029 s <<< FAILURE!
[INFO] org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
[INFO] 	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
[INFO] 	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
[INFO] 	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
[INFO] 	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
[INFO] 	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:31)
[INFO] 	at org.junit.jupiter.api.Assertions.assertTrue(Assertions.java:180)
[INFO] 	at io.quarkus.vault.VaultTransitITCase.keyVersionSignBatch(VaultTransitITCase.java:295)
[INFO] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[INFO] 	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[INFO] 	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
[INFO] 	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
[INFO] 	at io.quarkus.test.QuarkusUnitTest.runExtensionMethod(QuarkusUnitTest.java:499)
[INFO] 	at io.quarkus.test.QuarkusUnitTest.interceptTestMethod(QuarkusUnitTest.java:413)

@vsevel
Copy link
Contributor Author

vsevel commented Sep 20, 2023

I am going to try again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants