Revert to using HTTP when connecting to dev services containers #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes dev services by using the correct scheme, HTTP, when connecting to automatically started dev services containers.
|
/cc @bmscomp |
|
If you're not up-to-date on what this is related to see #178 where I originally commented on the closed PR |
|
@kdubb Thanks for the PR I was working right now on a same fix |
|
@bmscomp Can you add a test that actually uses a dev services container so we don't run into this problem again? |
|
We must merge this ASAP to ensure dev services is restored for before Quarkus 3.6.0 is released. @gsmet If I make a |
|
I was planning a release anyway for |
vsevel
approved these changes
Nov 20, 2023
|
@vsevel Should we cut a CR2 just to ensure a "release" works (since we don't yet have a test). |
|
see #199 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes dev services by using the correct scheme, HTTP, when connecting to automatically started dev services containers.
@vsevel I'm thinking we revert this to HTTP instead of passing the new
-dev-tlsflag and using HTTPS. My reasoning is just, as we've discussed previously, security products are generally updated slowly and the new flag requires Vault1.12+.We could selectively enable TLS but we'd need to be figuring it out prior to container startup based on the image tag. It can be done it's just work I don't have time for and we need to get this back in working order.
Also, we really need to add a unit test that actually uses a proper "dev services" container. Unfortunately I'm swamped at the moment.