replace wait() by communicate() to launch bindiff

quarkslab · Nov 8, 2023 · 87ca9a9 · 87ca9a9
1 parent 74f01a0
commit 87ca9a9
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/bindiff/bindiff.py b/bindiff/bindiff.py
@@ -180,7 +180,8 @@ def raw_diffing(p1_path: Union[Path, str], p2_path: Union[Path, str], out_diff:
 
         logging.debug(f"run diffing: {' '.join(cmd_line)}")
         process = subprocess.Popen(cmd_line, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
-        retcode = process.wait()
+        out, err = process.communicate()
+        retcode = process.returncode
         if retcode != 0:
             logging.error(f"differ terminated with error code: {retcode}")
             return False