Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite recipe bom 3.x #242

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Conversation

timtebeek
Copy link
Contributor

@timtebeek timtebeek commented Jan 20, 2025

Work in progress, as discussed after

/cc @gsmet to avoid duplicate work or conflicts

My process for these changes was to look at these specific Apache licensed versions of the recipes

Then from there modify them to strip out the call out to modify Jenkins build files for instance, simplify them where arguments are concerned, inline static nested class, and add the result here.

@timtebeek
Copy link
Contributor Author

timtebeek commented Jan 20, 2025

I've run ./mvnw license:third-party-report locally, which shows rewrite-quarkus for now still pulls in rewrite-migrate-java.

Alternatively we can exclude rewrite-migrate-java from rewrite-quarkus, as it's only used in a recipe not used here.
Edit: since rewrite-migrate-java is also coming in through camel, I think exclude for now is easiest and quickest.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for all this!

@gsmet gsmet merged commit 8a7cf6f into quarkusio:main Jan 28, 2025
1 check passed
@timtebeek timtebeek deleted the rewrite-recipe-bom-3.x branch January 28, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants