Skip to content

Commit

Permalink
Apply minor polish to MongoClients
Browse files Browse the repository at this point in the history
  • Loading branch information
geoand committed Feb 13, 2025
1 parent 22d8b35 commit 64f613c
Showing 1 changed file with 10 additions and 25 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ public ClusterSettingBuilder(MongoClientConfig config) {
this.config = config;
}

private MongoClientConfig config;
private final MongoClientConfig config;

@Override
public void apply(ClusterSettings.Builder builder) {
Expand Down Expand Up @@ -173,8 +173,8 @@ public ConnectionPoolSettingsBuilder(MongoClientConfig config, List<ConnectionPo
this.connectionPoolListeners = connectionPoolListeners;
}

private MongoClientConfig config;
private List<ConnectionPoolListener> connectionPoolListeners;
private final MongoClientConfig config;
private final List<ConnectionPoolListener> connectionPoolListeners;

@Override
public void apply(ConnectionPoolSettings.Builder builder) {
Expand Down Expand Up @@ -204,8 +204,8 @@ public SslSettingsBuilder(MongoClientConfig config, boolean disableSslSupport) {
this.disableSslSupport = disableSslSupport;
}

private MongoClientConfig config;
private boolean disableSslSupport;
private final MongoClientConfig config;
private final boolean disableSslSupport;

@Override
public void apply(SslSettings.Builder builder) {
Expand All @@ -218,7 +218,7 @@ public SocketSettingsBuilder(MongoClientConfig config) {
this.config = config;
}

private MongoClientConfig config;
private final MongoClientConfig config;

@Override
public void apply(SocketSettings.Builder builder) {
Expand All @@ -236,7 +236,7 @@ public ServerSettingsBuilder(MongoClientConfig config) {
this.config = config;
}

private MongoClientConfig config;
private final MongoClientConfig config;

@Override
public void apply(ServerSettings.Builder builder) {
Expand Down Expand Up @@ -439,8 +439,8 @@ private MongoCredential createMongoCredential(MongoClientConfig config) {
usernamePassword = new UsernamePassword(null, null);
}
// Create the MongoCredential instance.
String username = usernamePassword.getUsername();
char[] password = usernamePassword.getPassword();
String username = usernamePassword.username();
char[] password = usernamePassword.password();
MongoCredential credential;
if (mechanism == GSSAPI) {
credential = MongoCredential.createGSSAPICredential(username);
Expand Down Expand Up @@ -513,21 +513,6 @@ public void stop() {
}
}

private static class UsernamePassword {
private final String username;
private final char[] password;

public UsernamePassword(String username, char[] password) {
this.username = username;
this.password = password;
}

public String getUsername() {
return username;
}

public char[] getPassword() {
return password;
}
private record UsernamePassword(String username, char[] password) {
}
}

0 comments on commit 64f613c

Please sign in to comment.