Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to use the OpenShift certificate manager #42104

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

cescoffier
Copy link
Member

@cescoffier cescoffier commented Jul 24, 2024

OpenShift comes with its own version of the cert manager, based on annotations. See https://docs.openshift.com/container-platform/4.16/security/certificates/service-serving-certificate.html.

This PR extends the documentation to cover this OpenShift feature.

Copy link

quarkus-bot bot commented Jul 24, 2024

Thanks for your pull request!

Your pull request does not follow our editorial rules. Could you have a look?

  • description should not be empty, describe your intent or provide links to the issues this PR is fixing (using Fixes #NNNNN) or changelogs

This message is automatically generated by a bot.

This comment has been minimized.

Copy link
Member

@gsmet gsmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice content!

Not sure why you dropped this space but it needs to be added back.

For the titles, probably something to do in another PR someday, I just wanted to draw your attention on it for the future.

Please dismiss when space if fixed!

docs/src/main/asciidoc/tls-registry-reference.adoc Outdated Show resolved Hide resolved
docs/src/main/asciidoc/tls-registry-reference.adoc Outdated Show resolved Hide resolved
Copy link

quarkus-bot bot commented Jul 25, 2024

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit cb0d06e.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@cescoffier cescoffier merged commit bb9f95c into quarkusio:main Jul 25, 2024
5 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.14 - main milestone Jul 25, 2024
@cescoffier cescoffier deleted the openshift-cert-management branch July 25, 2024 08:12
Copy link

github-actions bot commented Jul 25, 2024

🎊 PR Preview 8a19237 has been successfully built and deployed to https://quarkus-pr-main-42104-preview.surge.sh/version/main/guides/

  • Images of blog posts older than 3 months are not available.
  • Newsletters older than 3 months are not available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

2 participants