Lazy System Properties for native image

[radcortez]

The GraalVM provides a lazy implementation to access system properties that are expensive to calculate: https://github.com/oracle/graal/blob/master/substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/SystemPropertiesSupport.java

Still, it ends up calculating all the properties anyway when System#getProperties() is called, which is a common call. Used, for instance, to get the list of names in Quarkus configuration, but also in GetPropertyAction#privilegedGetProperties() which is used in many JVM APIs, for instance, when determining the default timezone. Such initialization may cost a few milliseconds of the native image startup time (measured between 5-6, depending on the system).

https://quarkusio.zulipchat.com/#narrow/channel/187038-dev/topic/System.20Properties.20in.20Native.20Image.20.285.20to.206.20ms.20startup.20time.29

[quarkus-bot]

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit a63de4a.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

[gsmet]

@radcortez could you point me to where determining the default timezone is done?

[radcortez]

Yes, for the log pattern formatter:

[email protected]/java.lang.Thread.getStackTrace(Thread.java:623)
org.graalvm.nativeimage.builder/com.oracle.svm.core.jdk.SystemPropertiesSupport.getProperties(SystemPropertiesSupport.java:150)
[email protected]/java.lang.System.getProperties(System.java:461)
[email protected]/sun.security.action.GetPropertyAction.privilegedGetProperties(GetPropertyAction.java:153)
[email protected]/java.util.TimeZone.setDefaultZone(TimeZone.java:695)
[email protected]/java.util.TimeZone.getDefaultRef(TimeZone.java:685)
[email protected]/java.util.TimeZone.getDefault(TimeZone.java:674)
org.jboss.logmanager.formatters.FormatStringParser.getSteps(FormatStringParser.java:64)
org.jboss.logmanager.formatters.PatternFormatter.setPattern(PatternFormatter.java:80)
org.jboss.logmanager.formatters.ColorPatternFormatter.<init>(ColorPatternFormatter.java:54)
io.quarkus.runtime.logging.LoggingSetupRecorder.configureConsoleHandler(LoggingSetupRecorder.java:601)
io.quarkus.runtime.logging.LoggingSetupRecorder.initializeLogging(LoggingSetupRecorder.java:181)
io.quarkus.runner.recorded.LoggingResourceProcessor$setupLoggingRuntimeInit1041640541.deploy_0(Unknown Source)
io.quarkus.runner.recorded.LoggingResourceProcessor$setupLoggingRuntimeInit1041640541.deploy(Unknown Source)
io.quarkus.runner.ApplicationImpl.doStart(Unknown Source)
io.quarkus.runtime.Application.start(Application.java:101)
io.quarkus.runtime.ApplicationLifecycleManager.run(ApplicationLifecycleManager.java:121)
io.quarkus.runtime.Quarkus.run(Quarkus.java:77)
io.quarkus.runtime.Quarkus.run(Quarkus.java:48)
io.quarkus.runtime.Quarkus.run(Quarkus.java:137)
io.quarkus.runner.GeneratedMain.main(Unknown Source)

[gsmet]

I added a small question but I would like @zakkak @jerboaa or @galderz to have a look.

[gsmet]

@zakkak friendly ping :)

[zakkak]

It looks good to me but way more "intrunsive" than expected.

@radcortez do you see any reason not to propose this change to upstream Graal?

[radcortez]

@radcortez do you see any reason not to propose this change to upstream Graal?

Yes, I wanted to propose something to fix the issue there, but I also wanted to have something to quickly fix the problem on our side

[gsmet]

FWIW, I agree on the fact that's it's too intrusive. Let's try to improve upstream!

[radcortez]

Yes. I'll open up an issue, and I can also submit a PR to them.

[zakkak]

Upstream has changed this class quite a bit https://github.com/oracle/graal/blob/master/substratevm/src/com.oracle.svm.core/src/com/oracle/svm/core/jdk/SystemPropertiesSupport.java so you would first need to check if the issue is still reproducible with the latest GraalVM (you can get a build from https://github.com/graalvm/graalvm-ce-dev-builds/releases

[radcortez]

I opened this one on Graal VM side: oracle/graal#10630