-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add the possibility to configure a custom image for k8s dev container #48552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the possibility to configure a custom image for k8s dev container #48552
Conversation
This comment has been minimized.
This comment has been minimized.
🙈 The PR is closed and the preview is expired. |
This comment has been minimized.
This comment has been minimized.
...src/test/java/io/quarkus/kubernetes/client/devservices/it/profiles/DevServiceKubernetes.java
Outdated
Show resolved
Hide resolved
c63caef
to
41b5083
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@metacosm please review |
...es/src/test/java/io/quarkus/kubernetes/client/devservices/it/DevServicesKubernetesITest.java
Outdated
Show resolved
Hide resolved
...java/io/quarkus/kubernetes/client/runtime/internal/KubernetesDevServicesBuildTimeConfig.java
Outdated
Show resolved
Hide resolved
...java/io/quarkus/kubernetes/client/runtime/internal/KubernetesDevServicesBuildTimeConfig.java
Outdated
Show resolved
Hide resolved
db1725f
to
5f64db1
Compare
This comment has been minimized.
This comment has been minimized.
# Conflicts: # docs/src/main/asciidoc/kubernetes-dev-services.adoc # extensions/kubernetes-client/deployment/src/main/java/io/quarkus/kubernetes/client/deployment/DevServicesKubernetesProcessor.java
5f64db1
to
b209439
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable. It would be better if the image would override / not require the api version or flavor properties but this doesn't seem straightforward to do.
@metacosm Thanks again. I've been thinking about a solution, we could maybe parse the |
Status for workflow
|
Status for workflow
|
You're welcome. If you are interested in working on that, sure, go ahead as I think that would make more sense if it is possible to have a robust solution, which I'm not convinced of at this time, with only cursory look. |
I wanted to modify Flavor enum in order to make it a factory for the KubernetesContainer class but it's not in the same module so i tried to create a factory like method.
Be aware that with this implementation the flavor, apiversion & image-name properties should be coherent.
I was wondering if we should parse the image-name in order to deduce the flavor and api version but i wanted to make it simple for a first try.
For testing, i have no idea if it's possible de retrieve the image used by docker to run the container so i'm just checking for the property and used a mirror repository image before checking if the dev container is started.