Skip to content

Add the possibility to configure a custom image for k8s dev container #48552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

anisikram
Copy link
Contributor

@anisikram anisikram commented Jun 23, 2025

I wanted to modify Flavor enum in order to make it a factory for the KubernetesContainer class but it's not in the same module so i tried to create a factory like method.

Be aware that with this implementation the flavor, apiversion & image-name properties should be coherent.
I was wondering if we should parse the image-name in order to deduce the flavor and api version but i wanted to make it simple for a first try.

For testing, i have no idea if it's possible de retrieve the image used by docker to run the container so i'm just checking for the property and used a mirror repository image before checking if the dev container is started.

This comment has been minimized.

Copy link

github-actions bot commented Jun 23, 2025

🙈 The PR is closed and the preview is expired.

This comment has been minimized.

@anisikram anisikram force-pushed the add-config-for-custom-k8s-dev-container-image branch 2 times, most recently from c63caef to 41b5083 Compare June 24, 2025 21:07
@anisikram anisikram requested a review from geoand June 24, 2025 21:07

This comment has been minimized.

This comment has been minimized.

@geoand
Copy link
Contributor

geoand commented Jun 25, 2025

@metacosm please review

@anisikram anisikram force-pushed the add-config-for-custom-k8s-dev-container-image branch 2 times, most recently from db1725f to 5f64db1 Compare June 25, 2025 11:47
@anisikram anisikram requested a review from metacosm June 25, 2025 11:47

This comment has been minimized.

# Conflicts:
#	docs/src/main/asciidoc/kubernetes-dev-services.adoc
#	extensions/kubernetes-client/deployment/src/main/java/io/quarkus/kubernetes/client/deployment/DevServicesKubernetesProcessor.java
@anisikram anisikram force-pushed the add-config-for-custom-k8s-dev-container-image branch from 5f64db1 to b209439 Compare June 25, 2025 12:00
Copy link
Contributor

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. It would be better if the image would override / not require the api version or flavor properties but this doesn't seem straightforward to do.

@geoand geoand added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Jun 25, 2025
@anisikram
Copy link
Contributor Author

anisikram commented Jun 25, 2025

@metacosm Thanks again. I've been thinking about a solution, we could maybe parse the image-name property to deduce flavor and api version. If you want i can work on this in another issue/PR ?

Copy link

quarkus-bot bot commented Jun 25, 2025

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit b209439.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

Copy link

quarkus-bot bot commented Jun 25, 2025

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b209439.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

You can consult the Develocity build scans.

@geoand geoand merged commit bb4a65d into quarkusio:main Jun 25, 2025
33 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.25 - main milestone Jun 25, 2025
@quarkus-bot quarkus-bot bot added kind/enhancement New feature or request and removed triage/waiting-for-ci Ready to merge when CI successfully finishes labels Jun 25, 2025
@metacosm
Copy link
Contributor

@metacosm Thanks again. I've been thinking about a solution, we could maybe parse the image-name property to deduce flavor and api version. If you want i can work on this in another issue/PR ?

You're welcome. If you are interested in working on that, sure, go ahead as I think that would make more sense if it is possible to have a robust solution, which I'm not convinced of at this time, with only cursory look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom image registry for Kubernetes dev service
3 participants