update docs, make lockin lowpass config more explicit

quartiq · Jul 21, 2023 · 3f259fa · 3f259fa
1 parent 0e6ce3e
commit 3f259fa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 * Fixed a defect where powering up with Pounder attached would cause an internal panic.
 
+### Changed
+
+* `idsp` crate update to 0.10: `lockin` now uses a double second order lowpass.
+
 ## [v0.8.1](https://github.com/quartiq/stabilizer/compare/v0.8.0...v0.8.1) - 2022-11-14)
 
 * Fixed the python package dependencies

diff --git a/src/bin/lockin.rs b/src/bin/lockin.rs
@@ -37,7 +37,7 @@ use core::{
 use fugit::ExtU64;
 use mutex_trait::prelude::*;
 
-use idsp::{Accu, Chain, Complex, ComplexExt, Lockin, Lowpass, RPLL};
+use idsp::{Accu, Chain, Complex, ComplexExt, Lockin, Lowpass, RPLL, Filter};
 
 use stabilizer::{
     hardware::{
@@ -137,8 +137,8 @@ pub struct Settings {
     /// `lockin_k`
     ///
     /// # Value
-    /// The lockin low-pass coefficients. See [Lowpass]
-    lockin_k: [i32; 2],
+    /// The lockin low-pass coefficients. See [`idsp::Lowpass`] for determining them.
+    lockin_k: <Lowpass<2> as Filter>::Config,
 
     /// Specifies which harmonic to use for the lockin.
     ///