Skip to content

Permadelete .vdoc temp files, bypassing the trash #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DavisVaughan
Copy link
Collaborator

@DavisVaughan DavisVaughan commented May 19, 2025

Closes #708

I'm optimistic that this will help with #708. Even if it doesn't, we should still do this because right now these ephemeral files are piling up in the user's trash can, and they should really be permadeleted.

Before (I triggered completions and help):

Screenshot 2025-05-19 at 1 47 31 PM

After (same as above, note how no .vdoc files appear in my trash now):

Screenshot 2025-05-19 at 1 48 50 PM

@DavisVaughan DavisVaughan requested a review from cscheid May 19, 2025 17:53
Copy link
Collaborator

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working great! 🙌

With this change, I am not able to generate one of these .vdoc files in my Trash with either R or Python; I had thousands of these before.

@DavisVaughan DavisVaughan merged commit 3c666f0 into quarto-dev:main May 22, 2025
1 check passed
@DavisVaughan DavisVaughan deleted the fix/vdoc-delete-bypass-trash branch May 22, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hundreds of .vdocs appearing
2 participants