Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quartz-1.x links #78

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sumbach
Copy link

@sumbach sumbach commented Nov 23, 2020

When quartz-1.x directory was renamed to quartz-1.8.5 (later removed and replaced by quartz-1.8.6), the old quartz-1.x name continued to be used in internal links between documentation pages.

This PR aims to fix these broken links.

This PR should also resolve a couple minor Markdown syntax issues:

@jhouserizer
Copy link
Contributor

Hello! Thank you very much for your contribution and interest in helping improve the Quartz community.

After a period of dormancy, the Quartz project is back under steady maintenance by multiple volunteers, who are working to once again handle contributions such as yours.

We notice that your contribution was made without use of the DCO feature (the sign-off feature on commits via the -s option). Can you please update your PR with commits that use the -s option, agreeing to assign copyright ownership and other terms as described at the contributor agreement referenced here: https://github.com/quartz-scheduler/contributing/blob/main/CONTRIBUTING.md

You can easily add signoff to your previous commits by running (on your PR branch):

git commit --amend --signoff --no-edit 
git push -f

Or (for multiple commits):

# change 5 to the number of commits
git rebase HEAD~5 --signoff
git push -f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants