fix(QSelect): dialog positioning in select behavior #16097 #16711
+17
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Currently the dialog that appears from QSelect's behavior defaults to the middle of the screen (which is the dialog standard). However if use-input was set along with the behavior dialog setting it was hard-coded to the top of the screen. With this change just doing a general control of the dialog and defaulting to the standard (middle) position anyone who has a dialog with use-input will have an unexpected change. Now could code in support for both possibilities of dialog position determined default if use-input or not but seems unnecessary.
The fix though is simple in that adding dialog-position to top in the qselect to put it back.
The PR fulfills these requirements:
dev
branch (orv[X]
branch)fix: #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: