Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(QSelect): dialog positioning in select behavior #16097 #16711

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

IceIsFrozen
Copy link

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Currently the dialog that appears from QSelect's behavior defaults to the middle of the screen (which is the dialog standard). However if use-input was set along with the behavior dialog setting it was hard-coded to the top of the screen. With this change just doing a general control of the dialog and defaulting to the standard (middle) position anyone who has a dialog with use-input will have an unexpected change. Now could code in support for both possibilities of dialog position determined default if use-input or not but seems unnecessary.

The fix though is simple in that adding dialog-position to top in the qselect to put it back.

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant