Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format Date - Support ISO Week Year (GGGG) #17088

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

psevertson
Copy link

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Documentation
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the dev branch (or v[X] branch)
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on an Electron app
  • Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

Moment.js, Day.js, and other date libraries support date format tokens for the ISO week year (GGGG). This is so you can format dates like 2022-01-01 as 2021-W52 instead of the current YYYY token which returns the locale year.

https://momentjs.com/docs/#/parsing/string-format/:~:text=by%20moment.locale()-,gggg,-2014
https://day.js.org/docs/en/plugin/advanced-format

Co-Authored-By: Dylan Lathrum <[email protected]>
Co-Authored-By: Joseph Hale, MS SE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant