fix(vite-plugin): production builds (fix: #17267)

[yurks]

What kind of change does this PR introduce?

• Bugfix
• Feature
• Documentation
• Code style update
• Refactor
• Build-related changes
• Other, please describe:

Does this PR introduce a breaking change?

• Yes
• No

The PR fulfills these requirements:

• It's submitted to the dev branch (or v[X] branch)
• When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
• It's been tested on a Cordova (iOS, Android) app
• It's been tested on an Electron app
• Any necessary documentation has been added or updated in the docs or explained in the PR's description.

If adding a new feature, the PR's description includes:

• A convincing reason for adding this feature (to avoid wasting your time, it's best to start a new feature discussion first and wait for approval before working on it)

Other information:

[yurks]

#17267

[rstoenescu]

Hi @yurks ,

Thank you for contributing!

The problem with this is that the "vite preview" command is run by default with "serve" command and "production" mode. As per the Vite docs on the "vite preview" cmd: "Locally preview the production build". If we only look at the command as in this PR, then "vite preview" will produce a hybrid compilation, wrongly assuming it's a "dev" build.

What are your thoughts on this?

[rstoenescu]

Vite command	viteConf.command	viteConf.mode
serve	serve	development
build	build	production
preview	serve	production

[yurks]

@rstoenescu but preview could be run with another mode, like vite preview --mode staging, and current implementation will fail as well.

And yes, I forgot about preview ;) It looks like more correct condition for enabling tree-shaking would be command === 'serve' && mode === 'development'. What do you think?