Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Observable streams 🚰 #28

Merged
merged 8 commits into from
Jul 25, 2022
Merged

Observable streams 🚰 #28

merged 8 commits into from
Jul 25, 2022

Conversation

mrharpo
Copy link
Contributor

@mrharpo mrharpo commented Jul 24, 2022

Observable streams 🚰

Migrate components to use Observable streams, instead of m.redraw()

Progresses #26

State

  • cell.getStream to get access to states stream
  • Include type definition
  • Migrates clockTick action to directly modify streams
  • Migrates State viewer to use getStream
  • Removes m.redraw()

Clock

  • uses o(stream) to observe digits
  • Digit component with .digit class
  • Seperator component .seperator class
  • Re-adds OneIndex, TwoDecimal stream helpers
  • Minor css enhancements

Tracer

@mrharpo mrharpo added the enhancement ➕ New feature or request label Jul 24, 2022
@mrharpo mrharpo added this to the v0.4.0 Cells 🔬 milestone Jul 24, 2022
@mrharpo mrharpo requested a review from subcontrabass July 24, 2022 18:58
@mrharpo mrharpo self-assigned this Jul 24, 2022
Base automatically changed from cells to v0.4.0 July 25, 2022 01:28
@mrharpo mrharpo merged commit 35afaf3 into v0.4.0 Jul 25, 2022
@mrharpo mrharpo deleted the cell-clock branch July 25, 2022 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subcontrabass subcontrabass subcontrabass approved these changes

Assignees

@mrharpo mrharpo

Labels
enhancement ➕ New feature or request
Projects
None yet
Milestone
v0.4.0 Cells 🔬
Development

Successfully merging this pull request may close these issues.
2 participants
@mrharpo @subcontrabass