Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update grid-related examples #40

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Update grid-related examples #40

merged 3 commits into from
Nov 8, 2024

Conversation

jouvin
Copy link
Contributor

@jouvin jouvin commented Nov 7, 2024 •
edited
Loading

Hopefully fixed grid examples... In addition to fixed examples, it also fixes the test-library logic and removes clusters that have never been working...

@jouvin jouvin requested a review from jrha November 7, 2024 16:10
@jouvin jouvin force-pushed the update_grid_examples branch 4 times, most recently from a193da0 to 10ef968 Compare November 7, 2024 16:45
@jouvin
Copy link
Contributor Author

jouvin commented Nov 7, 2024

@jrha unfortunately not there yet... I don't understand the indent error about the missing colorama module as I copied the workflow definition from what was working on other repos... I probably missed something trivial!

@jouvin jouvin force-pushed the update_grid_examples branch from 10ef968 to 1b5cec6 Compare November 7, 2024 17:15
@jrha
Copy link
Member

jrha commented Nov 7, 2024

Fix for indenter in #41.

@jrha jrha added this to the 24.10 milestone Nov 7, 2024
@jouvin jouvin force-pushed the update_grid_examples branch 2 times, most recently from 3d7e4e4 to 4000393 Compare November 7, 2024 18:58
@jouvin
Copy link
Contributor Author

jouvin commented Nov 7, 2024

I think we have a major flaw in the current test test-library. The way create-vanilla-scdb is called what is tested is what has been already merged: there is no attempt to merge the current PR contents and so we are not testing the modifications contained on the PR. It is why we have all the errors in the current PR in this test, despite the PR is fixing these errors.

There was a --continuous-integration added at the time of Travis, I'm trying to see how to do something similar in GitHub actions.

@jouvin jouvin force-pushed the update_grid_examples branch 6 times, most recently from 65e0b8f to 1b57224 Compare November 7, 2024 20:59
@jouvin jouvin mentioned this pull request Nov 7, 2024
Merged
@jouvin jouvin force-pushed the update_grid_examples branch 4 times, most recently from c73e337 to 40b70b6 Compare November 7, 2024 22:17
@jouvin
Copy link
Contributor Author

jouvin commented Nov 7, 2024 •
edited
Loading

@jrha I think I fixed #40 (comment). The remaining error in test-library is caused by template-library-core missing some AII-related templates that are added by the releaser. May be we need to fix manually the repository to ensure we can pass the tests. We have a chicken&egg problem here.

I also need your help to fix the last indent problem. I am not sure what is the issue here and it is a little bit tedious to identify the culprit as indent doesn't display the file name where the problem is....

@jouvin jouvin force-pushed the update_grid_examples branch 2 times, most recently from 43d7ba8 to 4f4b023 Compare November 7, 2024 22:32
@jouvin jouvin mentioned this pull request Nov 7, 2024
Merged
@jouvin jouvin force-pushed the update_grid_examples branch 3 times, most recently from ab95dbb to b137150 Compare November 7, 2024 22:59
@jouvin jouvin force-pushed the update_grid_examples branch from afa9912 to 0b00dfe Compare November 8, 2024 11:23
@jouvin jouvin force-pushed the update_grid_examples branch from 0b00dfe to 577f41e Compare November 8, 2024 11:31
@jouvin
Copy link
Contributor Author

jouvin commented Nov 8, 2024

@jrha it should now be in a good shape! The only remaining problem is due to the missing quattor/aii/config.pan in template-library-core due to the releaser issues identified during 24.10.0-rc3 (quattor/release#360). I'd suggest to add temporarily (and manually) an empty version of quattor/aii/config.pan : I checked that it is enough to fix the problem in test-library and may limit the chicken&egg problem that we have...

@jrha
Copy link
Member

jrha commented Nov 8, 2024

Restore AII templates: quattor/template-library-core#234

@jouvin
Copy link
Contributor Author

jouvin commented Nov 8, 2024

All green now!

@jrha
Copy link
Member

jrha commented Nov 8, 2024

Excellent, thanks for the work on this!

@jouvin
Copy link
Contributor Author

jouvin commented Nov 8, 2024

I suggest to wait a little bit to merge this one. I'm adding in get-template-library the code required to support natively GitHub actions rather than defining the TRAVIS variables in test-library. Should be quick and will fix the problem in all repositories.

@jouvin jouvin mentioned this pull request Nov 8, 2024
Merged
@jouvin jouvin force-pushed the update_grid_examples branch from ff04e90 to 5be0c40 Compare November 8, 2024 15:31
@jouvin
Copy link
Contributor Author

jouvin commented Nov 8, 2024

Works as expected with the new get-template-library. Can be merged.

@jrha jrha force-pushed the update_grid_examples branch from 5be0c40 to 8e11c71 Compare November 8, 2024 16:21
jouvin added 2 commits November 8, 2024 16:21
@jouvin @jrha
Update grid-related examples
3b1dbe0 
- Use umd-4 rather than umd-3
- Use EL7 as the OS
- Remove obsolete machine type (LFC, WMS)
- Remove obsolete features
@jouvin @jrha
Remove broken clusters
8e11c71 
- Ceph, OpenNebula, OpenStack
@jrha jrha merged commit 9120a21 into quattor:master Nov 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrha jrha jrha approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
24.10
Development

Successfully merging this pull request may close these issues.
2 participants
@jouvin @jrha