Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Remove 'tip' until 'gimme' fixed #202

Merged
merged 2 commits into from
Jun 14, 2016
Merged

Conversation

jgsqware
Copy link
Contributor

gimmescript of Travis has incorrect behavior for the tipcommand. It return 1.4.1 instead of master.

I propose to remove tipuntil travis-ci/gimme#38 is fixed.

@jzelinskie
Copy link
Contributor

Even better, we can leave it there, but set the failure matrix to ignore its failures.
This is what Torus does.

@jzelinskie jzelinskie added area/testing related to improving test coverage reviewed/needs rework will be closed if review not addressed labels Jun 13, 2016
@jgsqware
Copy link
Contributor Author

What a great id, I don't even know that's possible. I'll WILL update the
PR

Le lun. 13 juin 2016 16:24, Jimmy Zelinskie [email protected] a
écrit :

Even better, we can leave it there, but set the failure matrix to ignore
its failures.
This is what Torus does
https://github.com/coreos/torus/blob/b2359cf8bf7cf5ecf267be774646bbf8df3a15d6/.travis.yml#L18-L20
.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#202 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ADJrq7Y4C3JSkHodNdi0qTu4tFeeHpBmks5qLWgHgaJpZM4I0EJk
.

@jgsqware
Copy link
Contributor Author

@jzelinskie I've updated .travis.yml as you say, and it's passing but again, gimme version doesn't change but retrieve the master branch now. I don't get why sometimes the behavior of gimme change.

@jzelinskie
Copy link
Contributor

jzelinskie commented Jun 14, 2016

@jgsqware That's fine. I don't think we should enforce tip passing even if gimme worked perfectly. However, we should be able to see if something will eventually be introduced into the language that will break us and that's what enabling this does.

LGTM

@jzelinskie jzelinskie added reviewed/lgtm and removed reviewed/needs rework will be closed if review not addressed labels Jun 14, 2016
@jzelinskie jzelinskie merged commit bed3662 into quay:master Jun 14, 2016
@jgsqware
Copy link
Contributor Author

👍 thanks

Le mar. 14 juin 2016 07:55, Jimmy Zelinskie [email protected] a
écrit :

Merged #202 #202.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#202 (comment), or mute the
thread
https://github.com/notifications/unsubscribe/ADJrq6BVHud_wWZhD6ilexOA_q6VOJs2ks5qLkJNgaJpZM4I0EJk
.

jordimassaguerpla added a commit to openSUSE/clair that referenced this pull request Jul 15, 2016
* upstream/master:
  updater: enable fetching of RHEL 5 vulnerabilities (quay#217)
  README: add reference to Klar tool
  improve v1 api docs header legibility
  godeps: Remove implicit git submodules
  readme: add various talks & slides
  readme: replace latest by v1.2.2 and add reference to container repositories
  travis: allow golang 'tip' failures (quay#202)
  updater: delete Ubuntu's repository upon bzr errors
  Modify URL of libpq documentation (quay#197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing related to improving test coverage
Development

Successfully merging this pull request may close these issues.

2 participants