Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Plugin RFC #1028

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

WIP: Plugin RFC #1028

wants to merge 11 commits into from

Conversation

hdonnay
Copy link
Member

@hdonnay hdonnay commented Aug 1, 2023

This is the code I wrote in parallel with writing #1032.

This branch has the net-new code added, with the caveat that the URN package needs an expanded test suite and a pass for correctness.

@hdonnay hdonnay force-pushed the hack/jsonschema branch 2 times, most recently from caef185 to 6166bcb Compare August 16, 2023 21:20
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Attention: Patch coverage is 33.09930% with 667 lines in your changes are missing coverage. Please review.

Project coverage is 53.49%. Comparing base (e8f9aff) to head (e6c8fd4).

Files Patch % Lines
internal/cmd/plugintool/mdbook.go 0.00% 243 Missing ⚠️
internal/cmd/plugintool/codegen.go 0.00% 123 Missing ⚠️
internal/plugin/plugin.go 50.00% 54 Missing and 14 partials ⚠️
internal/cmd/plugintool/main.go 0.00% 58 Missing ⚠️
toolkit/registry/plugins.go 54.38% 43 Missing and 9 partials ⚠️
internal/cmd/plugintool/directive.go 0.00% 49 Missing ⚠️
internal/plugin/metrics.go 45.71% 16 Missing and 3 partials ⚠️
indexer/ecosystem_loader.go 55.00% 14 Missing and 4 partials ⚠️
toolkit/urn/urn.go 87.32% 5 Missing and 4 partials ⚠️
libindex/plugin_init.go 57.14% 3 Missing and 3 partials ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1028      +/-   ##
==========================================
- Coverage   55.76%   53.49%   -2.27%     
==========================================
  Files         265      281      +16     
  Lines       16562    17559     +997     
==========================================
+ Hits         9236     9394     +158     
- Misses       6365     7190     +825     
- Partials      961      975      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hdonnay hdonnay force-pushed the hack/jsonschema branch 3 times, most recently from 2f9259e to 9c844bd Compare August 23, 2023 21:40
hdonnay added 11 commits April 16, 2024 09:42
This sets up some support infrastructure to unify naming across
claircore. The goal is to be able to pass around names as strings
instead of interface objects.

Signed-off-by: Hank Donnay <[email protected]>
This change adds a generic registry mechanism that is typesafe for users
and enforces consistent naming.

Signed-off-by: Hank Donnay <[email protected]>
This adds a package to implement the user side of the global registry
with a uniform creation and pooling workflow.

Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Signed-off-by: Hank Donnay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant