rpm: implement an RPM filescanner to discern RPM filepaths #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crozzy
force-pushed
the
rpm-filescanner
branch
2 times, most recently
from
21db95f to
f1bafd3
Compare
hdonnay
reviewed
Apr 12, 2024
crozzy
force-pushed
the
rpm-filescanner
branch
4 times, most recently
from
6e33ee1 to
217186a
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1320 +/- ##
==========================================
+ Coverage 55.25% 55.43% +0.18%
==========================================
Files 278 284 +6
Lines 17199 17932 +733
==========================================
+ Hits 9503 9941 +438
- Misses 6738 6945 +207
- Partials 958 1046 +88 ☔ View full report in Codecov by Sentry. |
crozzy
force-pushed
the
rpm-filescanner
branch
6 times, most recently
from
a248d33 to
9faca9c
Compare
|
I think I'll probably add some more test cases to the resolver but it'd be good to get some eyes on again. |
crozzy
force-pushed
the
rpm-filescanner
branch
4 times, most recently
from
66ca82d to
74673cc
Compare
crozzy
commented
Jun 13, 2024
crozzy
commented
Jun 13, 2024
crozzy
force-pushed
the
rpm-filescanner
branch
2 times, most recently
from
cbfd810 to
fbcd81a
Compare
hdonnay
reviewed
Jul 9, 2024
RTann
reviewed
Jul 9, 2024
RTann
reviewed
Jul 9, 2024
crozzy
force-pushed
the
rpm-filescanner
branch
3 times, most recently
from
4ba2ec7 to
41d429f
Compare
RTann
reviewed
Jul 10, 2024
RTann
reviewed
Jul 18, 2024
RTann
previously approved these changes
Jul 19, 2024
crozzy
force-pushed
the
rpm-filescanner
branch
3 times, most recently
from
a9aa141 to
e357ba9
Compare
RTann
approved these changes
Jul 22, 2024
We should be accounting for more than one file per layer and therefore this change (from map[layer_id]claircore.File to map[layer_id][]claircore.File) is needed. Signed-off-by: crozzy <[email protected]>
Using the filepaths discovered by the RPM filescanner we can judge whether or not a language package has been installed via RPM or not. Signed-off-by: crozzy <[email protected]>
The Resolver compares file paths gleaned from RPM DBs and compares them to a Package.Filepath to try and determine if a package needs to be removed from an index report because its RPM counterpart has already been included. Signed-off-by: crozzy <[email protected]>
crozzy
force-pushed
the
rpm-filescanner
branch
from
e357ba9 to
0eb95e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the filepaths discovered by the RPM filescanner we can judge whether or not a language package has been installed via RPM or not.
TODO: