EPSS enricher #1439
EPSS enricher #1439
Conversation
daynewlee
force-pushed
the
yli3/epssUpdater
branch
6 times, most recently
from
e876194 to
32941b1
Compare
enricher/epss/epss.go
Outdated
|
|
||
| const ( | ||
| // Type is the type of data returned from the Enricher's Enrich method. | ||
| Type = `message/vnd.clair.map.vulnerability; enricher=clair.epss schema=https://csrc.nist.gov/schema/nvd/feed/1.1/cvss-v3.x.json` |
There was a problem hiding this comment.
converting CSV file to json, not sure what the Type should look like.
There was a problem hiding this comment.
Yeah, we need to point to an actual schema here
There was a problem hiding this comment.
Do you have any suggestions? Do we need to define a schema in the enrichment package?
There was a problem hiding this comment.
I'm not sure if there is an equivalent for EPSS. @crozzy what do you suggest to do here?
There was a problem hiding this comment.
It should be the JSON schema of the EPSSItem when it is marshaled but I'm not entirely sure where would be a good place for it, any ideas @hdonnay ?
daynewlee
force-pushed
the
yli3/epssUpdater
branch
3 times, most recently
from
f5058ef to
7fbe5d3
Compare
daynewlee
force-pushed
the
yli3/epssUpdater
branch
2 times, most recently
from
34f4e08 to
5f69717
Compare
daynewlee
requested review from
crozzy,
RTann and
jvdm
and removed request for
a team
daynewlee
force-pushed
the
yli3/epssUpdater
branch
from
183e018 to
1f7633c
Compare
|
As of Nov 20th, we decide to include model version and score date in the enrichment data |
daynewlee
force-pushed
the
yli3/epssUpdater
branch
from
5712f01 to
843f8f6
Compare
daynewlee
force-pushed
the
yli3/epssUpdater
branch
3 times, most recently
from
9525df0 to
6bdb39d
Compare
enricher/epss/epss.go
Outdated
|
|
||
| const ( | ||
| // Type is the type of data returned from the Enricher's Enrich method. | ||
| Type = `message/vnd.clair.map.vulnerability; enricher=clair.epss schema=https://csrc.nist.gov/schema/nvd/feed/1.1/cvss-v3.x.json` |
There was a problem hiding this comment.
Yeah, we need to point to an actual schema here
|
Most everything I brought up seems to be addressed (apart from the new comments) |
enricher/epss/epss.go
Outdated
|
|
||
| const ( | ||
| // Type is the type of data returned from the Enricher's Enrich method. | ||
| Type = `message/vnd.clair.map.vulnerability; enricher=clair.epss schema=https://csrc.nist.gov/schema/nvd/feed/1.1/cvss-v3.x.json` |
There was a problem hiding this comment.
I'm not sure if there is an equivalent for EPSS. @crozzy what do you suggest to do here?
daynewlee
force-pushed
the
yli3/epssUpdater
branch
9 times, most recently
from
b41b7b1 to
9fa70d3
Compare
daynewlee
force-pushed
the
yli3/epssUpdater
branch
from
576d4d9 to
9f12ac0
Compare
| Int("count", len(ret)). | ||
| Msg("decoded enrichments") | ||
|
|
||
| if !errors.Is(err, io.EOF) { |
There was a problem hiding this comment.
just confirming, we expect an EOF once we exhaust all records?
daynewlee
force-pushed
the
yli3/epssUpdater
branch
2 times, most recently
from
e7cf505 to
f93b034
Compare
daynewlee
force-pushed
the
yli3/epssUpdater
branch
from
fd434d8 to
88e317d
Compare
Signed-off-by: daynewlee <[email protected]>
Signed-off-by: Yi Li <[email protected]>
Signed-off-by: Yi Li <[email protected]>
Signed-off-by: daynewlee <[email protected]>
Signed-off-by: daynewlee <[email protected]>
daynewlee
force-pushed
the
yli3/epssUpdater
branch
from
88e317d to
c5d4b9a
Compare
Epss enricher should be able to update, parse EPSS data and enrich vulnerability report with the data