next release #158
Open
next release #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raae
force-pushed
the
next
branch
4 times, most recently
from
c18ab45 to
fd932c9
Compare
Instead use the provider list fetched on prepublish.
raae
force-pushed
the
next
branch
4 times, most recently
from
7801465 to
b4c4e38
Compare
# [0.2.0-next.2](v0.2.0-next.1...v0.2.0-next.2) (2022-04-26) ### Bug Fixes * npm unignore prefetched-providers.json ([2dde20d](2dde20d))
# [0.2.0-next.3](v0.2.0-next.2...v0.2.0-next.3) (2022-04-26) ### Bug Fixes * use prepack to download provider list ([d421b84](d421b84))
daiyanze
reviewed
Apr 27, 2022
| const filePath = path.join(__dirname, "../.prefetched-providers.json"); | ||
| const file = await readFile(filePath); | ||
| return JSON.parse(file); | ||
| const rawProviders = require("./../prefetched-providers.json"); |
There was a problem hiding this comment.
I see... So the providers content is coupled with the NPM package itself.
Maybe we have to compromise until this issue's being fixed?
gatsbyjs/gatsby#35415
There was a problem hiding this comment.
It gets downloaded when the package is published. It could maybe be downloaded on install...
There was a problem hiding this comment.
This approach will also make the most sense when making a more general remark plugin I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.