Potential Fixes to various issues, including readMap implementation, ActionRequest Depreciation and method overrides

[smulder]

I am going to premise this with this is the absolute first time I have ever messed (and I stress messed) with java. I likely do not have the correct or full resources to fully build, run or interpret the output or tests. Many of which failed because something or another could not be initialized (see error from test build below).

I am hoping this just maybe somehow makes it easier to get this back up to date with elasticSearch 8.14.2 or even 8.15, though I just forked the 8.14.2 branch from dependabot

This will likely need edits by maintainers and that was left checked, but I am glad to do anything you can guide me to do.

I am proposing potential fixes to various issues, including readMap implementation, ActionRequest Depreciation and method overrides

Error output from tests:

LuceneQueryBuildingIntegrationTest » NoClassDefFound Could not initialize class org.elasticsearch.test.ESSingleNodeTestCase
QuerqyMappingsUpdate1To3IntegrationTest » NoClassDefFound Could not initialize class org.elasticsearch.test.ESSingleNodeTestCase
QuerqyMappingsUpdate2To3IntegrationTest » NoClassDefFound Could not initialize class org.elasticsearch.test.ESSingleNodeTestCase
RewriterIntegrationTest » NoClassDefFound Could not initialize class org.elasticsearch.test.ESSingleNodeTestCase
RewriterShardContextsTest » NoClassDefFound Could not initialize class org.elasticsearch.test.ESIntegTestCase
RewriterStoreIntegrationTest » NoClassDefFound Could not initialize class org.elasticsearch.test.ESIntegTestCase
InfoLoggingIntegrationTest » NoClassDefFound Could not initialize class org.elasticsearch.test.ESSingleNodeTestCase
InfoLoggingMultiShardIntegrationTest » NoClassDefFound Could not initialize class org.elasticsearch.test.ESTestCase
QuerqyQueryBuilderTest » NoClassDefFound Could not initialize class org.elasticsearch.test.ESTestCase
QueryBuildingIntegrationTest » NoClassDefFound Could not initialize class org.elasticsearch.test.ESSingleNodeTestCase
RewriterTest.testStreamSerializationWithParams:34 » EOF tried to read: 99 bytes but only 38 remaining
NumberUnitRewriterFactoryTest>ESTestCase.<clinit>:308 » Runtime unable to install test security manager
ReplaceRewriterIntegrationTest » NoClassDefFound Could not initialize class querqy.elasticsearch.rewriter.AbstractRewriterIntegrationTest
SimpleCommonRulesRewriterFactoryTest » NoClassDefFound Could not initialize class querqy.elasticsearch.rewriter.AbstractRewriterIntegrationTest
PutRewriterRequestTest.testStreamSerialization:80 » IO Can't read unknown type [99]
Tests run: 91, Failures: 0, Errors: 15, Skipped: 0

[smulder]

@renekrie, I know you said you don't have time until EOW, but I just wanted to tag you here so you see i sent this over. Let me know if it helps whenever you get a chance. Thanks! Scott

[renekrie]

Thank you @smulder! I really appreciate that you went into an area that was unknown to you. I will have a look!

[renekrie]

I've started to work on this. The new ES version seems to require some explicit ref handling so that we'd have to add decRef() to many responses in our tests (similar to what we see here: elastic/elasticsearch@6825cb2#diff-b8788d4233aba4fb12b9d4eb6637385b7baf628586e3ed7ae660b9b1d55e3fe2). I'll need a bit more time to understand whether this is really needed (it is a bit odd to require an explicit decRef from the consumer of the response - so I want to make sure, I didn't get this wrong)

[renekrie]

Superseded by #130