Skip to content

Commit

Permalink
update github contributing
Browse files Browse the repository at this point in the history
  • Loading branch information
queryluke committed Mar 26, 2019
1 parent 76df977 commit 17e88cb
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 109 deletions.
7 changes: 0 additions & 7 deletions .github/ISSUE_TEMPLATE/general-discussion.md

This file was deleted.

26 changes: 0 additions & 26 deletions .github/ISSUE_TEMPLATE/spell-proposal-template.md

This file was deleted.

40 changes: 0 additions & 40 deletions .github/ISSUE_TEMPLATE/spell-review-template.md

This file was deleted.

42 changes: 6 additions & 36 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,38 +1,8 @@
For the code savvy, you can always fork the repo, make changes and issue pull requests. Otherwise:
If you want to submit feedback or ask questions about the system's rules, you can do in three ways:

Otherwise, the standard for contributing ideas, improvements, site bugs, etc:
1. Use our [Feedback Form](https://goo.gl/forms/Q8Msv6TSm3y4Uy4F3)
2. Email us: [email protected]
3. Check out our subreddit: [/r/masseffect5e](https://www.reddit.com/r/masseffect5e/)

1. You'll need a GitHub account
2. In the repo, click the Issues tab. Here you'll find a list of past and present issues.

We define issues as anything ranging from a typo to a whole new addition to the system, such as a Race concept. However, before
opening a new issue, we only ask that you do a cusory seach of existing issues to see if the idea, bug, etc. already has been reported.

In the list of issues we use labels to designate the status:

#### Site specific labels
You can still comment on these, but they're not in the scope of theory crafting for the system.

`site enhancement` refers to a possible improvement to the website or webapp. For example, "add filters for weapon type"
`site bug` refers to a problem with the site. This might be a broken link or a typo.

#### Theory crafting, ideas, additions, and more
The bulk of the discussion for upcoming changes will be labeled with:

`discussion open` everyone is open comment and provide additional input.

However:

`discussion closed` means that we've either reached consensus (or made a final decision) and the change will be added in the next release milestone.
It could still take a few days or a weeks to get onto the site, depending on how involved the change is.

#### Contextual labels

`duplicate` means the issue has a duplicate somewhere else. The duplicate will be reference and the issue will be closed.

`wontfix` means the discussion is closed but no change is needed.

`completed for next release` is the label we use for changes that have been completed on the backend but haven't yet been published.
You should only see this label on `site enhancement` or `discussion complete`.

Otherwise, if you have any questions, you can email us at [email protected]
If the issue is with the website or you have a great idea for a website improvement, you can use on of the methods
above, or open an issue, here, on GitHub.

0 comments on commit 17e88cb

Please sign in to comment.