Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests #14

Merged
merged 3 commits into from
Mar 20, 2019
Merged

Add tests #14

merged 3 commits into from
Mar 20, 2019

Conversation

Yijia-Chen
Copy link
Member

@Yijia-Chen Yijia-Chen commented Mar 18, 2019 •
edited
Loading

WIP: Improve test coverage #12

@Yijia-Chen Yijia-Chen changed the title Add tests WIP: Add tests Mar 18, 2019
davidanthoff
davidanthoff requested changes Mar 19, 2019
View reviewed changes
Copy link
Member

@davidanthoff davidanthoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you resolve the merge conflict first? Otherwise CI won't run. All you need to do is merge master into this branch here, and it will complain, and then you can resolve the merge conflict.

test/REQUIRE Outdated
@@ -0,0 +1 @@
Dates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shouldn't be necessary, Dates is a stdlib, and those don't need to be listed in REQUIRE.

@davidanthoff davidanthoff added the enhancement New feature or request label Mar 19, 2019
@davidanthoff davidanthoff changed the title WIP: Add tests Add tests Mar 20, 2019
@davidanthoff davidanthoff merged commit 6394bdd into queryverse:master Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidanthoff davidanthoff davidanthoff requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yijia-Chen @davidanthoff