Fixing several buffer overflow in parse_arguments in n64split #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
for a university project we had look for buffer overflows in open source projects.
We have tested your software and discovered several buffer overflows in the n64split tool.
We have fixed those in this commit using
strncpy
instead ofstrcpy
.To reproduce the buffer overflow compile n64split with the gcc flag
-fno-stack-protector
and run it with the following input:./n64split $(python -c "print ''.join(c * 4096 for c in 'ABC') + 'D' * 72")
This will create a segmentation fault, because it will overwrite among others the return address of the main function.