add a DialAddr method to the client #50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49.
This change means that we don't have anything meaningful to return from
proxiedConn.RemoteAddr
, since we never learn the target's IP address. It seems like there's nothing we can do about it. The right thing to return would be the host name we dialed, but that doesn't fit into thenet.PacketConn
abstraction.Once we implement support for the RFC 9209 Proxy Status headers (see #2), we can fill in the value the proxy sent. But there's no guarantee that 1. the proxy sends this header value and 2. that the value is correct.