Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a DialAddr method to the client #50

Merged
merged 1 commit into from
Jul 4, 2024
Merged

add a DialAddr method to the client #50

merged 1 commit into from
Jul 4, 2024

Conversation

marten-seemann
Copy link
Member

Fixes #49.

This change means that we don't have anything meaningful to return from proxiedConn.RemoteAddr, since we never learn the target's IP address. It seems like there's nothing we can do about it. The right thing to return would be the host name we dialed, but that doesn't fit into the net.PacketConn abstraction.

Once we implement support for the RFC 9209 Proxy Status headers (see #2), we can fill in the value the proxy sent. But there's no guarantee that 1. the proxy sends this header value and 2. that the value is correct.

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 4 lines in your changes missing coverage. Please review.

Project coverage is 72.63%. Comparing base (ada223f) to head (2128d31).

Files Patch % Lines
client.go 76.47% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   71.47%   72.63%   +1.15%     
==========================================
  Files           4        4              
  Lines         284      296      +12     
==========================================
+ Hits          203      215      +12     
  Misses         57       57              
  Partials       24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann merged commit f8c4793 into master Jul 4, 2024
19 checks passed
@marten-seemann marten-seemann deleted the dial-addr branch July 4, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make it possible to dial a DNS name, not just an IP:port
1 participant