Change background to make code listing more legible in dark mode. #3738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Welsch <[email protected]>
|
Screen shot attached. Color can be changed in the CSS file by changing the --aimet-code-grey-dark variable. |
quic-hitameht
requested review from
quic-hitameht,
quic-akhobare and
quic-mtuttle
quic-hitameht
previously approved these changes
Jan 22, 2025
Signed-off-by: Dave Welsch <[email protected]>
|
Added a fix so that the "Out:" label in code output contrasts in dark mode: |
| @@ -42,6 +43,10 @@ li.toctree-l2 [for^="toctree-checkbox-"] { | |||
| padding-top: 10px; | |||
| } | |||
|
|
|||
| body[data-theme="dark"] .script-output::before { | |||
There was a problem hiding this comment.
can you share screenshot of before and after of code output for dark mode?
There was a problem hiding this comment.
"Before" screenshot below. "Output:" is illegible because it's black-on-black.
quic-bharathr
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.