Add new clang aliases that omit the {vendor} #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SidManning
approved these changes
Sep 16, 2024
|
I am trying to move these cmake cache files upstream so it'll be easier for us to maintain and easier for folks/buildbots to use when building. So I have updated that PR with this change: llvm/llvm-project#98712 |
androm3da
force-pushed
the
bcain/alias_nounknown
branch
2 times, most recently
from
2fd6e9a
to
1befab0
Compare
Some binutils were unintentionally omitted, so let's add these.
This should fix errors like the one below from the linux kernel:
+ mksysmap vmlinux System.map
+ /bin/bash /local/mnt/workspace/upstream/toolchain_for_hexagon/linux/scripts/mksysmap vmlinux System.map
/local/mnt/workspace/upstream/toolchain_for_hexagon/linux/scripts/mksysmap: line 44: hexagon-unknown-linux-musl-nm: command not found
+ on_exit
+ '[' 1 -ne 0 ']'
+ cleanup
Signed-off-by: Brian Cain <[email protected]>
The vendor is implicitly "unknown", so it's safe to omit and should be unambiguous when omitted. Suggested-by: Sid Manning <[email protected]> Signed-off-by: Brian Cain <[email protected]>
androm3da
force-pushed
the
bcain/alias_nounknown
branch
from
1befab0
to
862100e
Compare
quic-mathbern
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vendor is implicitly "unknown", so it's safe to omit and should be unambiguous when omitted.
Suggested-by: Sid Manning [email protected]