refactor(configuration): prefer Vector over std::vector

Reduce our use of std::vector to reduce binary bloat:
#689

src/quick-lint-js/cli/main.cpp

@@ -590,8 +590,9 @@ void run_lsp_server() {
     }
 
     void report_pending_watch_io_errors() {
+      Monotonic_Allocator temporary_allocator("report_pending_watch_io_errors");
       this->handler_.add_watch_io_errors(
-          Span<const Watch_IO_Error>(this->fs_.take_watch_errors()));
+          this->fs_.take_watch_errors(&temporary_allocator));
       this->handler_.flush_pending_notifications(this->writer_);
 #if QLJS_EVENT_LOOP2_PIPE_WRITE
       this->enable_or_disable_writer_events_as_needed();

src/quick-lint-js/configuration/change-detecting-filesystem-inotify.cpp

@@ -158,9 +158,12 @@ void Change_Detecting_Filesystem_Inotify::handle_poll_event(short revents) {
   }
 }
 
-std::vector<Watch_IO_Error>
-Change_Detecting_Filesystem_Inotify::take_watch_errors() {
-  return std::exchange(this->watch_errors_, std::vector<Watch_IO_Error>());
+Span<Watch_IO_Error> Change_Detecting_Filesystem_Inotify::take_watch_errors(
+    Monotonic_Allocator* allocator) {
+  Span<Watch_IO_Error> result = allocator->new_objects_copy(
+      Span<const Watch_IO_Error>(this->watch_errors_));
+  this->watch_errors_.clear();
+  return result;
 }
 
 void Change_Detecting_Filesystem_Inotify::read_inotify() {

src/quick-lint-js/configuration/change-detecting-filesystem-kqueue.cpp

@@ -103,9 +103,12 @@ void Change_Detecting_Filesystem_Kqueue::on_canonicalize_child_of_directory(
   }
 }
 
-std::vector<Watch_IO_Error>
-Change_Detecting_Filesystem_Kqueue::take_watch_errors() {
-  return std::exchange(this->watch_errors_, std::vector<Watch_IO_Error>());
+Span<Watch_IO_Error> Change_Detecting_Filesystem_Kqueue::take_watch_errors(
+    Monotonic_Allocator* allocator) {
+  Span<Watch_IO_Error> result = allocator->new_objects_copy(
+      Span<const Watch_IO_Error>(this->watch_errors_));
+  this->watch_errors_.clear();
+  return result;
 }
 
 void Change_Detecting_Filesystem_Kqueue::on_canonicalize_child_of_directory(

src/quick-lint-js/configuration/change-detecting-filesystem-win32.cpp

@@ -154,9 +154,12 @@ void Change_Detecting_Filesystem_Win32::clear_watches() {
   }
 }
 
-std::vector<Watch_IO_Error>
-Change_Detecting_Filesystem_Win32::take_watch_errors() {
-  return std::exchange(this->watch_errors_, std::vector<Watch_IO_Error>());
+Span<Watch_IO_Error> Change_Detecting_Filesystem_Win32::take_watch_errors(
+    Monotonic_Allocator* allocator) {
+  Span<Watch_IO_Error> result = allocator->new_objects_copy(
+      Span<const Watch_IO_Error>(this->watch_errors_));
+  this->watch_errors_.clear();
+  return result;
 }
 
 void Change_Detecting_Filesystem_Win32::cancel_watch(

src/quick-lint-js/configuration/change-detecting-filesystem.h

@@ -11,10 +11,12 @@
 #include <optional>
 #include <quick-lint-js/configuration/configuration-loader.h>
 #include <quick-lint-js/container/hash-map.h>
+#include <quick-lint-js/container/vector.h>
 #include <quick-lint-js/io/file-canonical.h>
 #include <quick-lint-js/io/file-handle.h>
 #include <quick-lint-js/io/file.h>
 #include <quick-lint-js/port/have.h>
+#include <quick-lint-js/port/memory-resource.h>
 #include <quick-lint-js/port/warning.h>
 #include <string>
 #include <vector>
@@ -72,7 +74,7 @@ class Change_Detecting_Filesystem_Inotify : public Configuration_Filesystem,
   std::optional<POSIX_FD_File_Ref> get_inotify_fd();
   void handle_poll_event(short revents);
 
-  std::vector<Watch_IO_Error> take_watch_errors();
+  Span<Watch_IO_Error> take_watch_errors(Monotonic_Allocator*);
 
  private:
   // Sets errno and returns false on failure.
@@ -82,7 +84,7 @@ class Change_Detecting_Filesystem_Inotify : public Configuration_Filesystem,
   void read_inotify();
 
   std::vector<int> watch_descriptors_;
-  std::vector<Watch_IO_Error> watch_errors_;
+  Vector<Watch_IO_Error> watch_errors_{"watch_errors_", new_delete_resource()};
   Result<POSIX_FD_File, POSIX_File_IO_Error> inotify_fd_;
 };
 #endif
@@ -111,7 +113,7 @@ class Change_Detecting_Filesystem_Kqueue : public Configuration_Filesystem,
 
   void handle_kqueue_event(const struct ::kevent&);
 
-  std::vector<Watch_IO_Error> take_watch_errors();
+  Span<Watch_IO_Error> take_watch_errors(Monotonic_Allocator*);
 
  private:
   struct File_ID {
@@ -142,7 +144,7 @@ class Change_Detecting_Filesystem_Kqueue : public Configuration_Filesystem,
   void* udata_;
 
   Hash_Map<Canonical_Path, Watched_File> watched_files_;
-  std::vector<Watch_IO_Error> watch_errors_;
+  Vector<Watch_IO_Error> watch_errors_{"watch_errors_", new_delete_resource()};
 };
 #endif
 
@@ -175,7 +177,7 @@ class Change_Detecting_Filesystem_Win32 : public Configuration_Filesystem {
 
   void clear_watches();
 
-  std::vector<Watch_IO_Error> take_watch_errors();
+  Span<Watch_IO_Error> take_watch_errors(Monotonic_Allocator*);
 
  private:
   struct Watched_Directory {
@@ -214,7 +216,7 @@ class Change_Detecting_Filesystem_Win32 : public Configuration_Filesystem {
       watched_directories_;
   std::vector<std::unique_ptr<Watched_Directory>>
       cancelling_watched_directories_;
-  std::vector<Watch_IO_Error> watch_errors_;
+  Vector<Watch_IO_Error> watch_errors_{"watch_errors_", new_delete_resource()};
 };
 #endif
 QLJS_WARNING_POP

test/test-configuration-loader.cpp

@@ -142,11 +142,11 @@ class Change_Detecting_Configuration_Loader {
     return this->loader_.unwatch_all_files();
   }
 
-  auto fs_take_watch_errors() {
+  auto fs_take_watch_errors(Monotonic_Allocator* allocator) {
 #if defined(_WIN32)
     std::lock_guard<Mutex> lock(this->mutex_);
 #endif
-    return this->fs_.take_watch_errors();
+    return this->fs_.take_watch_errors(allocator);
   }
 
   std::vector<Configuration_Change> detect_changes_and_refresh();
@@ -190,7 +190,10 @@ class Change_Detecting_Configuration_Loader {
 };
 
 class Test_Configuration_Loader : public ::testing::Test,
-                                  protected Filesystem_Test {};
+                                  protected Filesystem_Test {
+ public:
+  Monotonic_Allocator allocator{"Test_Configuration_Loader"};
+};
 
 TEST_F(Test_Configuration_Loader,
        file_with_no_config_file_gets_default_config) {
@@ -2101,7 +2104,7 @@ TEST_F(Test_Configuration_Loader,
       loader.watch_and_load_config_file(config_file, /*token=*/nullptr);
   EXPECT_TRUE(loaded_config.ok()) << loaded_config.error_to_string();
 
-  std::vector<Watch_IO_Error> errors = loader.fs_take_watch_errors();
+  Span<Watch_IO_Error> errors = loader.fs_take_watch_errors(&this->allocator);
   ASSERT_THAT(errors, ElementsAreArray({::testing::_}));
   const Watch_IO_Error& error = errors[0];
   EXPECT_EQ(error.io_error.error, EMFILE) << error.to_string();
@@ -2123,7 +2126,7 @@ TEST_F(Test_Configuration_Loader,
       loader.watch_and_load_config_file(config_file, /*token=*/nullptr);
   EXPECT_TRUE(loaded_config.ok()) << loaded_config.error_to_string();
 
-  std::vector<Watch_IO_Error> errors = loader.fs_take_watch_errors();
+  Span<Watch_IO_Error> errors = loader.fs_take_watch_errors(&this->allocator);
   std::vector<std::string> error_paths;
   for (Watch_IO_Error& error : errors) {
     EXPECT_EQ(error.io_error.error, ENOSPC) << error.to_string();
@@ -2152,7 +2155,7 @@ TEST_F(Test_Configuration_Loader,
       loader.watch_and_load_config_file(config_file, /*token=*/nullptr);
   EXPECT_TRUE(loaded_config.ok()) << loaded_config.error_to_string();
 
-  std::vector<Watch_IO_Error> errors = loader.fs_take_watch_errors();
+  Span<Watch_IO_Error> errors = loader.fs_take_watch_errors(&this->allocator);
   std::vector<std::string> error_paths;
   for (Watch_IO_Error& error : errors) {
     EXPECT_EQ(error.io_error.error, EMFILE) << error.to_string();
@@ -2193,7 +2196,7 @@ TEST_F(Test_Configuration_Loader,
         loader.watch_and_load_config_file(config_file, /*token=*/nullptr);
     EXPECT_TRUE(loaded_config.ok()) << loaded_config.error_to_string();
 
-    std::vector<Watch_IO_Error> errors = loader.fs_take_watch_errors();
+    Span<Watch_IO_Error> errors = loader.fs_take_watch_errors(&this->allocator);
     std::vector<std::string> error_paths;
     for (Watch_IO_Error& error : errors) {
       EXPECT_EQ(error.io_error.error, mock_error) << error.to_string();