Skip to content

Commit

Permalink
refactor(ci): delete unused quick-lint-js-github-builder Docker image
Browse files Browse the repository at this point in the history
The ghcr.io/quick-lint/quick-lint-js-github-builder Docker image is no
longer used. However, its Dockerfile exists and there are references to
it in some comments.

Clean up references to ghcr.io/quick-lint/quick-lint-js-github-builder
because we don't want to use it anymore.
  • Loading branch information
strager committed May 5, 2023
1 parent af41aa5 commit 3800544
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 89 deletions.
2 changes: 0 additions & 2 deletions .github/docker/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,5 @@ Actions workflows.

## Images

* `quick-lint-js-github-builder`: creates
`ghcr.io/quick-lint/quick-lint-js-github-builder`
* `quick-lint-js-github-cross-builder`: creates
`ghcr.io/quick-lint/quick-lint-js-github-cross-builder`
69 changes: 0 additions & 69 deletions .github/docker/quick-lint-js-github-builder/Dockerfile

This file was deleted.

13 changes: 0 additions & 13 deletions .github/docker/quick-lint-js-github-builder/README.md

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/build-and-test-dev-env-nix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
build:
name: build and test dev env nix
runs-on: ubuntu-latest
# TODO(strager): Use ghcr.io/quick-lint/quick-lint-js-github-builder.
# TODO(strager): Use a stable Docker image.
steps:
- name: checkout
uses: actions/checkout@v3
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/build-and-test-plugin-vscode.yml
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,8 @@ jobs:
os:
- {runs_on: macos-12, name: "macOS x86_64", platform_arch: "darwin-x64"}
- {runs_on: stracle-macos-aarch64, name: "macOS AArch64", platform_arch: "darwin-arm64"}
# FIXME(strager): For some reason, tests fail with the
# ghcr.io/quick-lint/quick-lint-js-github-builder Docker container.
# FIXME(strager): For some reason, tests fail with the a Docker
# container.
- {runs_on: ubuntu-latest, name: "Linux x86_64", platform_arch: "linux-x64", xvfb: true}
- {runs_on: windows-2022, name: "Windows x86", platform_arch: "win32-ia32"}
- {runs_on: windows-2022, name: "Windows x64", platform_arch: "win32-x64"}
Expand Down Expand Up @@ -155,7 +155,7 @@ jobs:
name: VS Code .vsix
needs: build
runs-on: ubuntu-latest
# TODO(strager): Use ghcr.io/quick-lint/quick-lint-js-github-builder.
# TODO(strager): Use a stable Docker image.
env:
QLJS_COLLECT_COPYRIGHT_NO_WARNINGS: 1
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-nix-install.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
build-nix:
name: test Nix install
runs-on: ubuntu-latest
# TODO(strager): Use ghcr.io/quick-lint/quick-lint-js-github-builder.
# TODO(strager): Use a stable Docker image.
steps:
- name: checkout
uses: actions/checkout@v3
Expand Down

0 comments on commit 3800544

Please sign in to comment.