Skip to content

Commit

Permalink
Rename VS Code plugin; prepare for new plugin
Browse files Browse the repository at this point in the history
I dislike the architecture of the existing VS Code plugin. I want to
switch away from WebAssembly.

Take a step toward deprecation by renaming the VS Code plugin to
quick-lint-js-wasm and moving it into the plugin/vscode-wasm/ directory.
Future commits will introduce a new plugin in plugin/vscode/.
  • Loading branch information
strager committed Aug 6, 2021
1 parent 241a016 commit 5acd842
Show file tree
Hide file tree
Showing 24 changed files with 17 additions and 17 deletions.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Copyright (C) 2020 Matthew Glazar
# See end of file for extended copyright information.

name: build and test VS Code extension
name: build and test VS Code extension (WASM)
on:
push:
pull_request:
Expand Down Expand Up @@ -91,7 +91,7 @@ jobs:
run: emmake cmake --install build --component vscode --prefix wasm

- name: JS configure
run: cd plugin/vscode && yarn
run: cd plugin/vscode-wasm && yarn
- name: JS test
run: |
DISPLAY=:1
Expand All @@ -102,26 +102,26 @@ jobs:
sleep 0.1 # Wait for Xvfb to start.
printf 'Started Xvfb\n' >&2
cd plugin/vscode
cd plugin/vscode-wasm
yarn test
kill %1
wait || :
- name: create extension
run: cd plugin/vscode && ./node_modules/.bin/vsce package --baseImagesUrl https://raw.githubusercontent.com/quick-lint/quick-lint-js/master/plugin/vscode/
run: cd plugin/vscode-wasm && ./node_modules/.bin/vsce package --baseImagesUrl https://raw.githubusercontent.com/quick-lint/quick-lint-js/master/plugin-wasm/vscode/

- name: upload build to workflow
uses: actions/upload-artifact@v2
with:
if-no-files-found: error
name: plugin-vscode-${{ github.sha }}
path: plugin/vscode/*.vsix
path: plugin/vscode-wasm/*.vsix
- name: upload build to long-term storage
if: ${{ github.event_name == 'push' && github.repository_owner == 'quick-lint' != null }}
uses: quick-lint/sftp-upload@master
with:
host: ${{ secrets.artifacts_host }}
local-file-globs: plugin/vscode/*.vsix
local-file-globs: plugin/vscode-wasm/*.vsix
private-key: ${{ secrets.artifacts_key }}
remote-directory: ${{ secrets.artifacts_root }}/builds/${{ github.sha }}/vscode/
user: ${{ secrets.artifacts_user }}
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ quick-lint-js finds many bugs, including:
* Using `await` in a non-`async` function
* Syntax errors

![Demonstration of quick-lint-js in Visual Studio Code](plugin/vscode/demo.webp)
![Demonstration of quick-lint-js in Visual Studio Code](plugin/vscode-wasm/demo.webp)

## Installing

Expand Down
4 changes: 2 additions & 2 deletions docs/RELEASE.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ Follow the following steps to release a new version of quick-lint-js:
* plugin/vim/quick-lint-js.vim/doc/quick-lint-js.txt
* plugin/vscode-lsp/README.md
* plugin/vscode-lsp/package.json
* plugin/vscode/BUILDING.md
* plugin/vscode/package.json
* plugin/vscode-wasm/BUILDING.md
* plugin/vscode-wasm/package.json
* src/quick-lint-js/version.h
* website/public/index.ejs.html
* website/public/install/index.ejs.html
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
6 changes: 3 additions & 3 deletions plugin/vscode/BUILDING.md → plugin/vscode-wasm/BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ package](../../wasm/README.md#Building).

Then, run the following command:

$ cd plugin/vscode/ # Navigate to this directory.
$ cd plugin/vscode-wasm/ # Navigate to this directory.
$ yarn install --force

Finally, run the following command to create `quick-lint-js-0.3.0.vsix`:
Finally, run the following command to create `quick-lint-js-wasm-0.3.0.vsix`:

$ ./node_modules/.bin/vsce package --baseImagesUrl https://raw.githubusercontent.com/quick-lint/quick-lint-js/master/plugin/vscode/
$ ./node_modules/.bin/vsce package --baseImagesUrl https://raw.githubusercontent.com/quick-lint/quick-lint-js/master/plugin/vscode-wasm/

## Testing

Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "quick-lint-js",
"name": "quick-lint-js-wasm",
"description": "Find JavaScript bugs with quick-lint-js",
"publisher": "quick-lint",
"version": "0.3.0",
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -475,7 +475,7 @@ async function pollAsync(callback) {
async function runAsync() {
// vscode-test activated the extension for us. We want tests to be activate and
// deactivate the extension at will.
let extension = vscode.extensions.getExtension("quick-lint.quick-lint-js");
let extension = vscode.extensions.getExtension("quick-lint.quick-lint-js-wasm");
await extension.activate();
await qljsExtension.deactivate();

Expand Down
File renamed without changes.
2 changes: 1 addition & 1 deletion website/public/vscode-demo.mp4
2 changes: 1 addition & 1 deletion website/public/vscode-demo.png
2 changes: 1 addition & 1 deletion website/public/vscode-demo.webp

0 comments on commit 5acd842

Please sign in to comment.