Merge branch 'master' into feature/warn-missing-fallthrough

.github/workflows/build-and-test.yml

@@ -23,7 +23,7 @@ jobs:
           - {runs_on: ubuntu-latest, name: "GCC 10 ASAN+UBSAN", container: "ghcr.io/quick-lint/quick-lint-js-github-gcc:v1", CC: gcc-10, CXX: g++-10, CFLAGS: "-fsanitize=address,undefined -fsanitize-address-use-after-scope -fno-sanitize-recover=address,undefined -fuse-ld=gold", CMAKE_BUILD_TYPE: "Debug", WARNINGS: "-Werror;{0}", CMAKE_FLAGS: "-G Ninja", ASAN_OPTIONS: "strict_string_checks=1:detect_stack_use_after_return=1:check_initialization_order=1:strict_init_order=1"}
           - {runs_on: ubuntu-latest, name: "GCC 10 Release", container: "ghcr.io/quick-lint/quick-lint-js-github-gcc:v1", CC: gcc-10, CXX: g++-10, CFLAGS: "", CMAKE_BUILD_TYPE: "Release", WARNINGS: "-Werror;{0}"}
           # TODO(strager): Enable Ninja for this job.
-          - {runs_on: ubuntu-latest, name: "GCC 10 dev", container: "ghcr.io/quick-lint/quick-lint-js-github-gcc:v1", CC: gcc-10, CXX: g++-10, CFLAGS: "", CMAKE_BUILD_TYPE: "Debug", WARNINGS: "-Werror;{0}", CMAKE_FLAGS: "-DQUICK_LINT_JS_FEATURE_DEBUG_SERVER=ON -DQUICK_LINT_JS_FEATURE_VECTOR_PROFILING=ON"}
+          - {runs_on: ubuntu-latest, name: "GCC 10 dev", container: "ghcr.io/quick-lint/quick-lint-js-github-gcc:v1", CC: gcc-10, CXX: g++-10, CFLAGS: "", CMAKE_BUILD_TYPE: "Debug", WARNINGS: "-Werror;{0}", CMAKE_FLAGS: "-DQUICK_LINT_JS_FEATURE_DEBUG_SERVER=ON -DQUICK_LINT_JS_FEATURE_EXTRA_DEBUG=ON -DQUICK_LINT_JS_FEATURE_VECTOR_PROFILING=ON"}
           # TODO(strager): Also test MinGW-based builds.
           - {runs_on: windows-latest, name: "MSVC", CFLAGS: "", CMAKE_BUILD_TYPE: "Debug", WARNINGS: ""}
           - {runs_on: windows-latest, name: "MSVC Release", CFLAGS: "", CMAKE_BUILD_TYPE: "Release", WARNINGS: ""}

CMakeLists.txt

@@ -125,6 +125,11 @@ option(
   "Enable the HTTP monitoring server at run-time"
   FALSE
 )
+option(
+  QUICK_LINT_JS_FEATURE_EXTRA_DEBUG
+  "Enable extra slow debug checking at run-time"
+  FALSE
+)
 option(
   QUICK_LINT_JS_FEATURE_VECTOR_PROFILING
   "Enable the QLJS_DUMP_VECTORS option at run-time"
@@ -147,6 +152,9 @@ quick_lint_js_disable_unwanted_warnings()
 if (WIN32)
   add_definitions(-D_WIN32_WINNT=0x0602)
 endif ()
+if (QUICK_LINT_JS_FEATURE_EXTRA_DEBUG)
+  add_compile_definitions(QLJS_DEBUG)
+endif ()
 
 # HACK(strager): Work around issues with CI. We should consider using
 # find_package(Python3) instead.

Formula/quick-lint-js.rb

@@ -4,7 +4,7 @@
 class QuickLintJs < Formula
   desc "Find bugs in your JavaScript code"
   homepage "https://quick-lint-js.com/"
-  url "https://c.quick-lint-js.com/releases/2.16.0/source/quick-lint-js-2.16.0.tar.gz"
+  url "https://c.quick-lint-js.com/releases/2.18.0/source/quick-lint-js-2.18.0.tar.gz"
   license "GPL-3.0-or-later"
   head "https://github.com/quick-lint/quick-lint-js.git", branch: "master"
 

benchmark/benchmark-cli-location.cpp

@@ -7,7 +7,7 @@
 #include <quick-lint-js/fe/source-code-span.h>
 #include <quick-lint-js/generate-code.h>
 #include <quick-lint-js/port/char8.h>
-#include <quick-lint-js/util/narrow-cast.h>
+#include <quick-lint-js/util/cast.h>
 
 namespace quick_lint_js {
 namespace {

benchmark/benchmark-configuration-loader.cpp

@@ -7,7 +7,7 @@
 #include <quick-lint-js/configuration/configuration-loader.h>
 #include <quick-lint-js/io/file.h>
 #include <quick-lint-js/io/temporary-directory.h>
-#include <quick-lint-js/util/narrow-cast.h>
+#include <quick-lint-js/util/cast.h>
 #include <string>
 
 namespace quick_lint_js {

benchmark/benchmark-lsp-document-text.cpp

@@ -10,7 +10,7 @@
 #include <quick-lint-js/lsp/lsp-document-text.h>
 #include <quick-lint-js/lsp/lsp-location.h>
 #include <quick-lint-js/port/char8.h>
-#include <quick-lint-js/util/narrow-cast.h>
+#include <quick-lint-js/util/cast.h>
 #include <random>
 #include <vector>
 

benchmark/benchmark-lsp-location.cpp

@@ -7,7 +7,7 @@
 #include <quick-lint-js/generate-code.h>
 #include <quick-lint-js/lsp/lsp-location.h>
 #include <quick-lint-js/port/char8.h>
-#include <quick-lint-js/util/narrow-cast.h>
+#include <quick-lint-js/util/cast.h>
 
 namespace quick_lint_js {
 namespace {

benchmark/benchmark-lsp/README.md

@@ -6,14 +6,14 @@ This directory contains a tool which measures the speed of LSP servers.
 
 Install the LSP servers you want to benchmark:
 
+* **Biome**: Run `yarn` in the `biome/` directory.
 * **Deno**: Install [Deno][]. Ensure the `deno` command is in `$PATH`.
 * **ESLint**: Run `yarn` in the `eslint/` directory. Then, run
   `npm ci && npm run compile:server` in the `eslint/node_modules/vscode-eslint/`
   directory.
 * **Flow**: Run `yarn` in the `flow/` directory.
 * **RSLint**: Install [RSLint's rslint_lsp crate][install-rslint]. Ensure the
   `rslint-lsp` command is in `$PATH`.
-* **Rome**: Run `yarn` in the `rome/` directory.
 * **TypeScript**: Run `yarn` in the `typescript/` and `typescript-jsx/`
   directories.
 * **quick-lint-js**: Install quick-lint-js. Ensure the `quick-lint-js` command

benchmark/benchmark-lsp/benchmark-config.cpp

@@ -304,10 +304,11 @@ Benchmark_Config Benchmark_Config::load() {
       },
 
       Benchmark_Config_Server{
-          .name = "Rome",
-          .program_name = "Rome",
+          .name = "Biome",
+          .program_name = "Biome",
           .command = {"./run.sh"},
-          .cwd = "rome/",
+          .cwd = "biome/",
+          .supports_jsx = true,
       },
 
       Benchmark_Config_Server{
@@ -423,8 +424,8 @@ Benchmark_Config Benchmark_Config::load() {
       },
 
       Benchmark_Config_Program{
-          .name = "Rome",
-          .get_metadata = []() { return get_yarn_packages_versions("rome"); },
+          .name = "Biome",
+          .get_metadata = []() { return get_yarn_packages_versions("biome"); },
       },
 
       Benchmark_Config_Program{

benchmark/benchmark-lsp/rome/package.json → benchmark/benchmark-lsp/biome/package.json

@@ -1,5 +1,5 @@
 {
   "dependencies": {
-    "rome": "*"
+    "@biomejs/biome": "*"
   }
 }

benchmark/benchmark-lsp/rome/run.sh → benchmark/benchmark-lsp/biome/run.sh

@@ -7,8 +7,8 @@ set -e
 set -u
 
 here="$(dirname "${0}")"
-"${here}/node_modules/.bin/rome" stop >&2
-exec "${here}/node_modules/.bin/rome" lsp-proxy
+"${here}/node_modules/.bin/biome" stop >&2
+exec "${here}/node_modules/.bin/biome" lsp-proxy
 
 # quick-lint-js finds bugs in JavaScript programs.
 # Copyright (C) 2020  Matthew "strager" Glazar

benchmark/benchmark-lsp/biome/yarn.lock

@@ -0,0 +1,45 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
+# yarn lockfile v1
+
+
+"@biomejs/biome@*":
+  version "1.3.1"
+  resolved "https://registry.yarnpkg.com/@biomejs/biome/-/biome-1.3.1.tgz#6ab36d619e04ebd22ca96a7ea3386acd3bddd1d8"
+  integrity sha512-ufGCBj8ZNbF+vZDZscqvvLIGsh8M4BduQoJ1X3nm8c9Dupp8gzAKibZSWDLLcgnsAVeKEmWwY6r3Wv/JIa0LgA==
+  optionalDependencies:
+    "@biomejs/cli-darwin-arm64" "1.3.1"
+    "@biomejs/cli-darwin-x64" "1.3.1"
+    "@biomejs/cli-linux-arm64" "1.3.1"
+    "@biomejs/cli-linux-x64" "1.3.1"
+    "@biomejs/cli-win32-arm64" "1.3.1"
+    "@biomejs/cli-win32-x64" "1.3.1"
+
+"@biomejs/[email protected]":
+  version "1.3.1"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-darwin-arm64/-/cli-darwin-arm64-1.3.1.tgz#170b0063686112dc667f1b40170d83da19216241"
+  integrity sha512-m3cBroQftLFYFh3to6RO4ooLqZsE2K9yf5xOlDjm6D4Vrgq85XFwDOxjjJyGGDjDPQ55xGunm80qmGr8jTjiyA==
+
+"@biomejs/[email protected]":
+  version "1.3.1"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-darwin-x64/-/cli-darwin-x64-1.3.1.tgz#170569dbdc874e2b926790dbf66f32bf05ea0a85"
+  integrity sha512-i2yDivc/HHBRFJMoRUUPsFs9pKK0NnS/8tQg/uqNsAkLMF9OKZCCxtUJPmpUBHpdQ2f39An1cVpFmCIEv0uYJQ==
+
+"@biomejs/[email protected]":
+  version "1.3.1"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-linux-arm64/-/cli-linux-arm64-1.3.1.tgz#8c26ad89eb8bab3a680ede83430e593ceed4ac0a"
+  integrity sha512-H56MB7Mf59snzG+nLpfS2j3jXsJ+a6aQOBeRiT0rgn44FZ63yI9jWNIgN1+Xylsa8shmwtquOkoxLS/4KKt0Qg==
+
+"@biomejs/[email protected]":
+  version "1.3.1"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-linux-x64/-/cli-linux-x64-1.3.1.tgz#47604e949f4cb9c4343e03a088cd86f7768a4359"
+  integrity sha512-8ENayCpYXXC77a7AxDNjC+pPKMYteLzysxhkCCZ7Gd2sWtrH8iMM45JL8wQJhoHz5NT3+qgsfGafiNuxeVAVlg==
+
+"@biomejs/[email protected]":
+  version "1.3.1"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-win32-arm64/-/cli-win32-arm64-1.3.1.tgz#0a32fee3f71971854df5bf126250661dd09b2465"
+  integrity sha512-gAx/E949/1/jQDwG9nTspVtjikBI/y7RbbUwwBVABF1bcAUC63VhrHfKJRbM7VTXMlZ7n9YrxkyMww8vf40qcQ==
+
+"@biomejs/[email protected]":
+  version "1.3.1"
+  resolved "https://registry.yarnpkg.com/@biomejs/cli-win32-x64/-/cli-win32-x64-1.3.1.tgz#dc5d5f4198333de084ee35773a3f8681847cd2d0"
+  integrity sha512-+08eKmEdVM7d4UxY/tff2aPXbeUNNp6wwH7v0FbrE+25mH9lhELgylEk4+k6OLXOcDT7KDAduzP2f9CuM/Aj9w==