refactor(website): Use article in og:type tag in blog articles.
#1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k1ng440
changed the title
article in og:type tag in blog articles.article in og:type tag in blog articles.
strager
requested changes
Sep 19, 2023
strager
reviewed
Sep 19, 2023
Comment on lines
+4
to
+7
| %> <% if (typeof meta.blogDate !== 'undefined') { %> | ||
| <meta property="og:type" content="article" /> | ||
| <meta property="article:section" content="Technology" /> | ||
| <meta property="article:published_time" content="<%= meta.blogDate %>" /> |
There was a problem hiding this comment.
We know this is a blog article because the file is called blog-head.ejs.html. Shouldn't we only put the if around article:published_time?
Suggested change
| %> <% if (typeof meta.blogDate !== 'undefined') { %> | |
| <meta property="og:type" content="article" /> | |
| <meta property="article:section" content="Technology" /> | |
| <meta property="article:published_time" content="<%= meta.blogDate %>" /> | |
| %> | |
| <meta property="og:type" content="article" /> | |
| <meta property="article:section" content="Technology" /> | |
| <% if (typeof meta.blogDate !== 'undefined') { %> | |
| <meta property="article:published_time" content="<%= meta.blogDate %>" /> |
There was a problem hiding this comment.
This file is also included in /blog.
strager
approved these changes
Sep 19, 2023
strager
approved these changes
Sep 22, 2023
|
Landed as commit b2bc1a3. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1080 for the intention of this pull request.