fix(typescript): report E0429 for class 'extends' clause #1116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Match functionality of `implements` and `interface ... extends` by
reporting an error when the user defines a class that uses a generic
within an `extends` clause without a space between `<` like so `<<`.
For clarity, quick-lint-js reports an error in the following snippet
that uses `<<`.
```
export class D<T> {}
export class D2 extends D<<U>() => number> {}
```
quick-lint-js does _not_ report an error in this snippet since it uses
`< <`.
```
export class D<T> {}
export class D2 extends D< <U>() => number> {}
```
arieldon
force-pushed
the
report_e0429_for_extends_clause
branch
from
cdffac8 to
1f49f7c
Compare
strager
approved these changes
Dec 17, 2023
| @@ -1511,9 +1511,22 @@ Expression* Parser::parse_expression_remainder(Parse_Visitor_Base& v, | |||
| case Token_Type::less: | |||
| case Token_Type::less_less: | |||
| if (this->options_.typescript) { | |||
| // class C< <T>() => RetType> // Valid. | |||
| // class C<<T>() => RetType> // Invalid. | |||
| if (prec.in_class_extends_clause && | |||
There was a problem hiding this comment.
Oh cool, I didn't know we had in_class_extends_clause. That makes this so easy!
|
Landed as commit 58d0516. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #1114.
It matches functionality of
implementsandinterface ... extendsby reporting an error when the user defines a class that uses a generic within anextendsclause without a space between<like so<<.For clarity, quick-lint-js reports an error in the following snippet that uses
<<.quick-lint-js does not report an error in this snippet since it uses
< <.