Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typescript): add new diag for "import type" with import alias #1140

Merged
merged 1 commit into from
Jan 3, 2024
Merged

feat(typescript): add new diag for "import type" with import alias #1140

merged 1 commit into from
Jan 3, 2024

Conversation

koopiehoop
Copy link
Contributor

This closes #1139. I've moved type_span before switch statement so we can have better diagnostic instead of pointing on import keyword.

strager
strager requested changes Dec 31, 2023
View reviewed changes
Copy link
Collaborator

@strager strager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your patch looks good. Thanks! However, there is an issue with the documentation (see the 'must fix' comment).

src/quick-lint-js/fe/parse-statement.cpp Outdated Show resolved Hide resolved
src/quick-lint-js/fe/parse-statement.cpp Outdated Show resolved Hide resolved
test/test-parse-typescript-namespace.cpp Show resolved Hide resolved
docs/errors/E0717.md Outdated Show resolved Hide resolved
docs/errors/E0717.md Outdated Show resolved Hide resolved
@koopiehoop koopiehoop force-pushed the disallow_import_type_with_import_alias branch 2 times, most recently from 9af0364 to f6432f2 Compare January 2, 2024 15:18
@koopiehoop koopiehoop requested a review from strager January 2, 2024 15:22
@koopiehoop koopiehoop force-pushed the disallow_import_type_with_import_alias branch from f6432f2 to ca04c6f Compare January 2, 2024 15:22
@koopiehoop koopiehoop force-pushed the disallow_import_type_with_import_alias branch from ca04c6f to a21013d Compare January 2, 2024 15:56
@strager strager merged commit c081fed into quick-lint:master Jan 3, 2024
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strager strager strager approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8$: disallow 'import type a = mynamespace;'
2 participants
@koopiehoop @strager