feat: add new diag "namespace alias" in javascript code #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot Thank you for your contribution! Like many free software projects, you must sign our Contributor License Agreement before we can accept your contribution. EDIT: All contributors have signed quick-lint-js' Contributor License Agreement (CLA-v1.md). |
|
I have read and hereby agree to quick-lint-js' Contributor License Agreement (CLA-v1.md). |
|
recheck |
UnfairBots
force-pushed
the
rename_import_alias_namespace_alias_add_new_diag_namespace_alias
branch
from
d1d27a6 to
9e773ad
Compare
strager
approved these changes
Feb 25, 2024
…script code to separate E0274, rename some test functions from import_alias to namespace_alias This closes quick-lint#1138
UnfairBots
force-pushed
the
rename_import_alias_namespace_alias_add_new_diag_namespace_alias
branch
from
963b20d to
89ed8df
Compare
|
Hello @strager, I updated new patch and resolved your comments, please review and let me know if any change is required. |
|
Landed as Git commit 24040d4. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add new diag E0719, using Typescript namespace alias in javascript code to separate E0274, rename some test functions from import_alias to namespace_alias
This closes #1138